chore: add a test aggregation workflow #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This, naturally, also fails without #21, so we're kinda stuck merging that first and rebasing this. Given that some of the integration test flows are working properly I believe I have at least the CI wrinkles smoothed out. |
Tieske
previously approved these changes
Dec 2, 2023
rainest
force-pushed
the
chore/require-pass
branch
from
25097e8 to
2fc9fa0
Compare
rainest
force-pushed
the
chore/require-pass
branch
from
a3a3d1d to
afa7ced
Compare
I mean it Dependabot, cease!
|
Now includes (the third or fourth) downgrade attempt also, since dependabot is too fast and jumps in to help before tests here could run again and pass the merge requirements :| |
Tieske
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #21 (comment) why things merged without passing tests, well, we simply have no required tests! We have a require status checks branch protection rule with no required status checks configured, same as deck did. I'm not sure if anything was preventing merges with failures in the past.
This cannibalizes a similar KIC workflow that aggregates required test workflows into a single
passedstatus. Note that we still need to add this to the branch protection rules after for it to have effect.