fix: retaining tags on entities while using select-tags #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now, while running deck with --select-tags, the tags are removed from the `tags` field on each entity. This was done to reduce duplication. However, this has been confusing for a lot of our deck users. This change removes the tag removal function calls from all entities.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 28.60% 28.63% +0.03%
==========================================
Files 106 106
Lines 15958 15934 -24
==========================================
- Hits 4564 4562 -2
+ Misses 10912 10890 -22
Partials 482 482 ☔ View full report in Codecov by Sentry. |
|
@Prashansa-K how do I approach testing these changes? |
harshadixit12
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As of now, while running deck with --select-tags,
the tags are removed from the
tagsfield oneach entity. This was done to reduce duplication.
However, this has been confusing for a lot of our
deck users.
This change removes the tag removal function
calls from all entities.
Issues resolved
For Kong/deck#1454
Documentation
Testing