Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix codegen #148

Merged
merged 1 commit into from
Dec 9, 2024
Merged

ci: fix codegen #148

merged 1 commit into from
Dec 9, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Nov 21, 2024

Summary

Fix code generation and add it to CI.

Without this change we get:

make update-codegen ; make verify-codegen
./scripts/update-deepcopy-gen.sh
unknown flag: --input-dirs
Usage of deepcopy-gen:
      --add_dir_header                   If true, adds the file directory to the header of the log messages
      --alsologtostderr                  log to standard error as well as files (no effect when -logtostderr=true)
      --bounding-dirs strings            Comma-separated list of import paths which bound the types for which deep-copies will be generated.
      --go-header-file string            the path to a file containing boilerplate header text; the string "YEAR" will be replaced with the current 4-digit year
      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                   If non-empty, write log files in this directory (no effect when -logtostderr=true)
      --log_file string                  If non-empty, use this log file (no effect when -logtostderr=true)
      --log_file_max_size uint           Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
      --logtostderr                      log to standard error instead of files (default true)
      --one_output                       If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
      --output-file string               the name of the file to be generated (default "generated.deepcopy.go")
      --skip_headers                     If true, avoid header prefixes in the log messages
      --skip_log_headers                 If true, avoid headers when opening log files (no effect when -logtostderr=true)
      --stderrthreshold severity         logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=true) (default 2)
  -v, --v Level                          number for the log level verbosity
      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging
unknown flag: --input-dirs
make: *** [Makefile:19: update-codegen] Error 2
./scripts/verify-codegen.sh
cp: file/kong_json_schema.json: No such file or directory
make: *** [Makefile:14: verify-codegen] Error 1

Full changelog

  • [Implement ...]
  • [Fix ...]

Issues resolved

Fix #XXX

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@pmalek pmalek self-assigned this Nov 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.71%. Comparing base (2b9555f) to head (be40da6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   28.71%   28.71%           
=======================================
  Files         106      106           
  Lines       15817    15817           
=======================================
  Hits         4542     4542           
  Misses      10796    10796           
  Partials      479      479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek marked this pull request as ready for review November 21, 2024 10:35
@pmalek pmalek enabled auto-merge (squash) December 9, 2024 11:11
@pmalek pmalek merged commit ba02fcd into main Dec 9, 2024
19 checks passed
@pmalek pmalek deleted the fix-codegen branch December 9, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants