Test/avoid filling defaults in config for kong #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
force-pushed
the
test/avoid-filling-defaults-in-config-for-kong
branch
from
2e3d206 to
2b957ff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix/avoid-filling-defaults-in-config-for-kong #135 +/- ##
==============================================================================
Coverage 42.74% 42.74%
==============================================================================
Files 75 75
Lines 8809 8809
==============================================================================
Hits 3765 3765
Misses 4581 4581
Partials 463 463 ☔ View full report in Codecov by Sentry. |
samugi
changed the base branch from
main
to
fix/avoid-filling-defaults-in-config-for-kong
samugi
approved these changes
Aug 27, 2024
|
I replaced otel with another plugin that can be tested in 2.8 as well (and that likely will be less subject to schema changes in the future) |
samugi
merged commit 9a81082
into
fix/avoid-filling-defaults-in-config-for-kong
18 checks passed
samugi
added a commit
that referenced
this pull request
Aug 27, 2024
* add tests for plugin filling default values --------- Co-authored-by: samugi <[email protected]>
samugi
added a commit
that referenced
this pull request
Aug 27, 2024
* fix(diff+file): avoid filling defaults in config for kong the previous logic was filling defaults in the configuration that was passed to Kong. This was problematic, especially where nils were populated as defaults, e.g. if a shorthand_field was passed with some value and the corresponding new field is auto-populated as `nil` by decK , the auto-populated nil value would take precedence in Kong thus causing the shorthand_field to be ignored (https://konghq.atlassian.net/browse/KAG-5157). This change applies the default values only to configurations used for diff, the original configuration is always passed to Kong as is. * Test/avoid filling defaults in config for kong (#135) * add tests for plugin filling default values --------- Co-authored-by: samugi <[email protected]> --------- Co-authored-by: Tao Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY_GOES_HERE
Add tests for changes in #133.
Full changelog
Issues resolved
Fix #XXX
Documentation
Testing