-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add helm upgrade tests #95
Conversation
e66cdeb
to
7972254
Compare
4487fd8
to
47a4ed3
Compare
e06832f
to
f015318
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested it with KGO EE? It seems it should work, but it's better to be sure 😉
Good point. I've created https://github.com/Kong/gateway-operator-enterprise/pull/137 to test this |
Co-authored-by: Jakub Warczarek <[email protected]>
@programmer04 https://github.com/Kong/gateway-operator-enterprise/pull/137#issuecomment-2096470896 |
What this PR does / why we need it:
This PR adds some basic scaffolding for helm upgrade tests
Which issue this PR fixes
Part of #155
Special notes for your reviewer:
In order to perform update form pre 1.2 to 1.2+ we need to be able to disableControlPlane
andGateway
controllers because their respective CRDs (ControlPlane
andGatewayConfiguration
) got a breaking change in 1.2 (bump fromv1alpha1
tov1beta
without a KGO version that would allow a smooth transition).This requires a change in the chart which would allow setting args because only KGO 1.2+ supports configuration via env. Kong/charts#1058 implements that.The upgrade from pre 1.2 to 1.2 and up is not done as helm chart (used in this test suite) only contains the CRDs from 1.2 and since helm still doesn't provide CRD management there's no easy way to achieve that (well apart from applying the CRDs manually but we'd need to add manual steps for that).
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect significant changes