Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add installing ingress-controller CRDs in integration tests #905

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Nov 28, 2024

What this PR does / why we need it:

It seems that we've missed the fact that KGO also requires old KIC CRDs to run, otherwise it complains:

2024-11-28T14:16:08.082188322Z stderr F 2024-11-28T14:16:08Z	error	controller-runtime.source.EventHandler	if kind is a CRD, it should be installed before calling Start	{"kind": "UDPIngress.configuration.konghq.com", "error": "no matches for kind \"UDPIngress\" in version \"configuration.konghq.com/v1beta1\""}
2024-11-28T14:16:08.086461072Z stderr F 2024-11-28T14:16:08Z	error	controller-runtime.source.EventHandler	if kind is a CRD, it should be installed before calling Start	{"kind": "KongIngress.configuration.konghq.com", "error": "no matches for kind \"KongIngress\" in version \"configuration.konghq.com/v1\""}
2024-11-28T14:16:08.174483894Z stderr F 2024-11-28T14:16:08Z	error	controller-runtime.source.EventHandler	if kind is a CRD, it should be installed before calling Start	{"kind": "KongCustomEntity.configuration.konghq.com", "error": "no matches for kind \"KongCustomEntity\" in version \"configuration.konghq.com/v1alpha1\""}
2024-11-28T14:16:08.272399653Z stderr F 2024-11-28T14:16:08Z	error	controller-runtime.source.EventHandler	if kind is a CRD, it should be installed before calling Start	{"kind": "TCPIngress.configuration.konghq.com", "error": "no matches for kind \"TCPIngress\" in version \"configuration.konghq.com/v1beta1\""}
2024-11-28T14:16:08.272541718Z stderr F 2024-11-28T14:16:08Z	error	controller-runtime.source.EventHandler	if kind is a CRD, it should be installed before calling Start	{"kind": "IngressClassParameters.configuration.konghq.com", "error": "no matches for kind \"IngressClassParameters\" in version \"configuration.konghq.com/v1alpha1\""}
2024-11-28T14:16:08.27261278Z stderr F 2024-11-28T14:16:08Z	error	controller-runtime.source.EventHandler	if kind is a CRD, it should be installed before calling Start	{"kind": "KongClusterPlugin.configuration.konghq.com", "error": "no matches for kind \"KongClusterPlugin\" in version \"configuration.konghq.com/v1\""}
2024-11-28T14:16:08.273440923Z stderr F 2024-11-28T14:16:08Z	error	controller-runtime.source.EventHandler	if kind is a CRD, it should be installed before calling Start	{"kind": "KongUpstreamPolicy.configuration.konghq.com", "error": "no matches for kind \"KongUpstreamPolicy\" in version \"configuration.konghq.com/v1beta1\""}
...
2024-11-28T14:18:08.118149505Z stderr F Error: failed to wait for KongV1KongIngress caches to sync: timed out waiting for cache to be synced for Kind *v1.KongIngress

Discovered in KGO 1.4.1 release workflow diagnostics:

@pmalek pmalek self-assigned this Nov 28, 2024
@pmalek pmalek marked this pull request as ready for review November 28, 2024 15:15
@pmalek pmalek requested a review from a team as a code owner November 28, 2024 15:15
@pmalek pmalek enabled auto-merge (squash) November 28, 2024 15:17
@pmalek pmalek merged commit 8174ef7 into main Nov 28, 2024
22 checks passed
@pmalek pmalek deleted the tests-integration-install-ingress-controller-CRDs branch November 28, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants