fix(dataplane): properly default deprecated service account name #856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
API server fills in the deprecated service account field based on what's set in the service account name field. This causes the operator to incorrectly assume there's a diff which needs an update on the
Deployment
.This PR fixes that by copying what's in
serviceAccountName
toserviceAccount
(deprecated) field.This is a temporary workaround until #500 (or similar) gets implemented.