Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add logs to KPI integration test #842

Merged
merged 1 commit into from
Nov 4, 2024
Merged

tests: add logs to KPI integration test #842

merged 1 commit into from
Nov 4, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Nov 4, 2024

What this PR does / why we need it:

Add logs to TestKongPluginInstallationEssentials to have better visibility into why test failed:

https://github.com/Kong/gateway-operator/actions/runs/11662121353/job/32467841588?pr=836

    test_kongplugininstallation.go:96: 
        	Error Trace:	/home/runner/work/gateway-operator/gateway-operator/test/integration/test_kongplugininstallation.go:376
        	            				/home/runner/go/pkg/mod/golang.org/[email protected]/src/runtime/asm_amd64.s:1700
        	Error:      	Not equal: 
        	            	expected: 200
        	            	actual  : 503
    test_kongplugininstallation.go:96: 
        	Error Trace:	/home/runner/work/gateway-operator/gateway-operator/test/integration/test_kongplugininstallation.go:370
        	            				/home/runner/work/gateway-operator/gateway-operator/test/integration/test_kongplugininstallation.go:96
        	Error:      	Condition never satisfied
        	Test:       	TestIntegration/TestKongPluginInstallationEssentials

@pmalek pmalek requested a review from a team as a code owner November 4, 2024 10:46
@pmalek pmalek enabled auto-merge (squash) November 4, 2024 11:20
@pmalek pmalek requested a review from programmer04 November 4, 2024 11:20
programmer04
programmer04 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@programmer04 programmer04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pmalek pmalek merged commit c22fad3 into main Nov 4, 2024
21 checks passed
@pmalek pmalek deleted the kpi-test-logs branch November 4, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@programmer04 programmer04 programmer04 approved these changes

Assignees
No one assigned
Labels
area/tests test-flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmalek @programmer04