fix(dataplane): do not set ExternalTrafficPolicy for ClusterIP services #812
+108
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
fix-dp-ingress-service-ext-traffic-policy
branch
from
a164e98 to
9ce9659
Compare
pmalek
force-pushed
the
fix-dp-ingress-service-ext-traffic-policy
branch
5 times, most recently
from
376c329 to
bddc692
Compare
czeslavo
approved these changes
Oct 28, 2024
pmalek
force-pushed
the
fix-dp-ingress-service-ext-traffic-policy
branch
from
bddc692 to
c8088f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Disallow setting
ExternalTrafficPolicyforDataPlane's ingress service whentype=ClusterIP.Additionally, do not set the default value (
Cluster). Only use what's provided in user provided manifests.Which issue this PR fixes
Fixes #
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes