Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(konnect): handle CACertificate creation conflicts #769

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

tao12345666333
Copy link
Member

What this PR does / why we need it:

Follow up on #749 for KongCACertificate.

@tao12345666333 tao12345666333 force-pushed the fix/KongCACertificate-conflicts branch 3 times, most recently from 12ce1cc to 2d377a6 Compare October 22, 2024 11:13
@tao12345666333 tao12345666333 self-assigned this Oct 22, 2024
@tao12345666333 tao12345666333 added this to the KGO v1.4.x milestone Oct 22, 2024
@tao12345666333 tao12345666333 marked this pull request as ready for review October 22, 2024 11:14
@tao12345666333 tao12345666333 requested a review from a team as a code owner October 22, 2024 11:14
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the tiny nit for extracting constants it looks good to me. 👍

@tao12345666333 tao12345666333 force-pushed the fix/KongCACertificate-conflicts branch from 0bcc61a to 41bf49c Compare October 22, 2024 12:34
@tao12345666333 tao12345666333 enabled auto-merge (squash) October 22, 2024 12:34
@tao12345666333 tao12345666333 merged commit 32bbcd9 into main Oct 22, 2024
21 checks passed
@tao12345666333 tao12345666333 deleted the fix/KongCACertificate-conflicts branch October 22, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants