Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): fix issues with e2e tests (wrong Gateway image, etc.) #768

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Oct 21, 2024

What this PR does / why we need it:

This PR fixes issues with e2e tests required to pull the newest KGO OSS in the EE version.

  • setting proper registry for KGO EE and OSS depending on repo
  • replace hardcoded values and make them work for OSS and EE
  • some nits, like better logging, typos, etc.

Prerequisite for

@programmer04 programmer04 added this to the KGO v1.4.x milestone Oct 21, 2024
@programmer04 programmer04 force-pushed the e2e-impr branch 6 times, most recently from 6241236 to 625b2ef Compare October 22, 2024 16:45
@programmer04 programmer04 self-assigned this Oct 22, 2024
@programmer04 programmer04 force-pushed the e2e-impr branch 3 times, most recently from 7c7e89b to 943ee93 Compare October 22, 2024 20:35
test/helpers/defaults.go Show resolved Hide resolved
test/helpers/defaults.go Outdated Show resolved Hide resolved
test/e2e/test_helm_install_upgrade.go Outdated Show resolved Hide resolved
@programmer04 programmer04 changed the title chore(tests): fix issues with e2e tests chore(tests): fix issues with e2e tests (wrong Gateway image, etc.) Oct 23, 2024
@programmer04 programmer04 marked this pull request as ready for review October 23, 2024 08:54
@programmer04 programmer04 requested a review from a team as a code owner October 23, 2024 08:54
@programmer04 programmer04 requested a review from czeslavo October 23, 2024 08:55
@czeslavo czeslavo merged commit b0fe781 into main Oct 23, 2024
21 checks passed
@czeslavo czeslavo deleted the e2e-impr branch October 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants