Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(konnect): add handleDeleteError to uniformly handle delete errors #760

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 18, 2024

What this PR does / why we need it:

Introduces handleDeleteError which handles delete errors uniformly in every object type delete operation.

@pmalek pmalek self-assigned this Oct 18, 2024
@pmalek pmalek force-pushed the konnect-handleDeleteError branch from ecf7f90 to 19c3673 Compare October 18, 2024 19:33
@pmalek pmalek force-pushed the konnect-handleDeleteError branch from 19c3673 to 4254804 Compare October 21, 2024 07:58
@pmalek pmalek added this to the KGO v1.4.x milestone Oct 21, 2024
@pmalek pmalek marked this pull request as ready for review October 21, 2024 07:58
@pmalek pmalek requested a review from a team as a code owner October 21, 2024 07:58
@pmalek pmalek enabled auto-merge (squash) October 21, 2024 08:06
@pmalek pmalek force-pushed the konnect-handleDeleteError branch from 9e230f3 to a534781 Compare October 21, 2024 08:45
@pmalek pmalek force-pushed the konnect-handleDeleteError branch from a534781 to a6df10f Compare October 21, 2024 09:01
@pmalek pmalek merged commit 70a3880 into main Oct 21, 2024
21 checks passed
@pmalek pmalek deleted the konnect-handleDeleteError branch October 21, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants