Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix helm upgrade test by correctly asserting whether KGO upgrades result in DataPlane image changes #691

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 3, 2024

What this PR does / why we need it:

The test has been incorrectly checking whether the DataPlane has been patches while in reality it should check for its Deployment patch.

Additionally add a pretty print of said Deployment to verify its state if the test fails to extend this log:

=== FAIL: test/e2e TestE2E/TestHelmUpgrade/upgrade_from_1.3.0_to_current/DataPlane_deployment_is_not_patched_after_operator_upgrade (180.00s)
    test_helm_install_upgrade.go:404: DataPlane "154a4ae9-47e0-4422-95d4-717c7d8a43ee/gw-upgrade-130-current-tvthm-kjsvm" got patched but it shouldn't: <nil>
    test_helm_install_upgrade.go:404: 
        	Error Trace:	/home/runner/work/gateway-operator/gateway-operator/test/e2e/test_helm_install_upgrade.go:404
        	Error:      	Condition never satisfied
        	Test:       	TestE2E/TestHelmUpgrade/upgrade_from_1.3.0_to_current/DataPlane_deployment_is_not_patched_after_operator_upgrade

=== FAIL: test/e2e TestE2E/TestHelmUpgrade/upgrade_from_1.3.0_to_current (238.57s)

More importantly this PR changes the assertions around DataPlane deployments being patched between 1.2.3 -> 1.3.0 and 1.3.0 to latest because a default DP image change was introduced between those versions.

  • from 1.2.3 to 1.3.0 default DataPlane image changed from 3.6 to 3.7
  • from 1.3.0 to latest main default DataPlane image changed from 3.7 to 3.8

@pmalek pmalek self-assigned this Oct 3, 2024
@pmalek pmalek force-pushed the e2e-helm-upgrade-test-check-dataplane-deployment branch 4 times, most recently from b686d61 to c9b41e9 Compare October 3, 2024 15:28
@pmalek pmalek changed the title tests: fix helm upgrade test by checking DataPlane's deployment not the DataPlane itself tests: fix helm upgrade test by correctly asserting whether KGO upgrades result in DataPlane image changes Oct 3, 2024
@pmalek pmalek added this to the KGO v1.4.x milestone Oct 3, 2024
@pmalek pmalek force-pushed the e2e-helm-upgrade-test-check-dataplane-deployment branch 3 times, most recently from b122541 to 464aa05 Compare October 3, 2024 17:47
@pmalek pmalek marked this pull request as ready for review October 4, 2024 07:22
@pmalek pmalek requested a review from a team as a code owner October 4, 2024 07:22
@pmalek pmalek enabled auto-merge (squash) October 4, 2024 07:28
@pmalek pmalek force-pushed the e2e-helm-upgrade-test-check-dataplane-deployment branch from 464aa05 to 0b05d75 Compare October 4, 2024 08:16
@pmalek pmalek force-pushed the e2e-helm-upgrade-test-check-dataplane-deployment branch from 0b05d75 to f76abb2 Compare October 4, 2024 12:12
@pmalek pmalek merged commit 4bffb35 into main Oct 4, 2024
21 checks passed
@pmalek pmalek deleted the e2e-helm-upgrade-test-check-dataplane-deployment branch October 4, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants