Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(konnect): Add SDKWrapper to allow using mock SDK in reconcilers #543

Merged
merged 9 commits into from
Sep 5, 2024
Merged

test(konnect): Add SDKWrapper to allow using mock SDK in reconcilers #543

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e86ca7c
refactor(konnect): add SDK interface types for each entity type
pmalek Aug 20, 2024
7b552ae
tests: add mockery for Konnect SDK
pmalek Aug 20, 2024
8bbceb0
tests: add mocks for KongService SDK
pmalek Aug 23, 2024
0b5df8e
add plugin SDK interface and mock
randmonkey Sep 3, 2024
778a9d9
refactor SDKFactory to allow using mock SDK in reconcilers
randmonkey Sep 3, 2024
34a6352
add mocks for all submodules of Konnect SDK
randmonkey Sep 5, 2024
954bb84
move mock SDK code to *_mock.go to allow them being imported by other…
randmonkey Sep 5, 2024
30f3c73
Update controller/konnect/reconciler_generic_test.go
randmonkey Sep 5, 2024
51fdeed
Merge branch 'main' into test/mock_test_for_reconciler
randmonkey Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,3 +146,8 @@ issues:
linters:
- revive
text: "exported: exported"
# Generated mock SDKs does not need comments on generated methods.
- path: controller/konnect/ops/.*_mock\.go
linters:
- revive
text: "exported: exported"
7 changes: 6 additions & 1 deletion .mockery.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ inpackage: True
disable-version-string: True
with-expecter: True

filename: "{{ trimSuffix .InterfaceFile \".go\" | base | lower }}_mock_test.go"
filename: "{{ trimSuffix .InterfaceFile \".go\" | base | lower }}_mock.go"
dir: "{{ .InterfaceDir }}"
mockname: "Mock{{ .InterfaceName }}"
outpkg: "{{ .PackageName }}"
Expand All @@ -13,3 +13,8 @@ packages:
interfaces:
ControlPlaneSDK:
ServicesSDK:
RoutesSDK:
ConsumersSDK:
ConsumerGroupSDK:
PluginSDK:
MeSDK:
0 ...ler/konnect/ops/controlplane_mock_test.go → controller/konnect/ops/controlplane_mock.go
View file
Open in desktop
File renamed without changes.
264 changes: 264 additions & 0 deletions controller/konnect/ops/kongconsumer_mock.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading