-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(konnect): support Secrets in KonnectAPIAuthConfiguration #459
Conversation
965f502
to
7b5aae7
Compare
7b5aae7
to
47ff0d7
Compare
03286f0
to
ede4fe4
Compare
1aae819
to
fafd5d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a CHANGELOG entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some existing code still importing Konnect related types from configurationv1alpha1
. They should be also updated after Kong/kubernetes-configuration
is bumped.
65b9649
to
f02726b
Compare
Co-authored-by: Grzegorz Burzyński <[email protected]>
Co-authored-by: Grzegorz Burzyński <[email protected]>
f02726b
to
9d0105b
Compare
Needed to rebase on |
What this PR does / why we need it:
Add support for tokens in Secrets in
KonnectAPIAuthConfiguration
reconciler.This allows the following:
The
konghq.com/credential=konnect
is required to efficiently watch for changes in Secrets.Depends on #456 and Kong/kubernetes-configuration#16Which issue this PR fixes
Part of #431
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect significant changes