feat: DataplaneKonnectExtension CRD
#453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlavacca
force-pushed
the
mlavacca/dataplane-konnect
branch
5 times, most recently
from
89e8ac6 to
b09db39
Compare
mlavacca
changed the title
dataplane_konnect_extension CRDDataplaneKonnectExtension CRD
mlavacca
force-pushed
the
mlavacca/dataplane-konnect
branch
3 times, most recently
from
fa3c962 to
56279cb
Compare
pmalek
reviewed
Aug 1, 2024
mlavacca
force-pushed
the
mlavacca/dataplane-konnect
branch
2 times, most recently
from
8baa7e9 to
0cc163f
Compare
Yep, I added an example under |
pmalek
reviewed
Aug 13, 2024
randmonkey
reviewed
Aug 20, 2024
mlavacca
force-pushed
the
mlavacca/dataplane-konnect
branch
2 times, most recently
from
ede4d5c to
6e5a01f
Compare
mlavacca
force-pushed
the
mlavacca/dataplane-konnect
branch
from
6e5a01f to
078d6d3
Compare
randmonkey
reviewed
Sep 4, 2024
czeslavo
reviewed
Sep 4, 2024
Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
randmonkey
approved these changes
Sep 5, 2024
mlavacca
force-pushed
the
mlavacca/dataplane-konnect
branch
from
69cde85 to
cc2851d
Compare
mlavacca
force-pushed
the
mlavacca/dataplane-konnect
branch
from
cc2851d to
78a8135
Compare
Signed-off-by: Mattia Lavacca <[email protected]>
mlavacca
force-pushed
the
mlavacca/dataplane-konnect
branch
from
78a8135 to
6f9c392
Compare
czeslavo
approved these changes
Sep 5, 2024
pmalek
reviewed
Sep 9, 2024
| type DataPlaneKonnectExtensionSpec struct { | ||
| // ControlPlaneRef is a reference to a ControlPlane this DataPlaneKonnectExtension is associated with. | ||
| // +kubebuilder:validation:Required | ||
| ControlPlaneRef configurationv1alpha1.ControlPlaneRef `json:"controlPlaneRef"` |
There was a problem hiding this comment.
Just a note based on a sync with @mlavacca: when we get to implement the konnectNamespacedRef we should make the CP ref immutable to prevent going from 1 type of CP ref to another (unless that gets implemented)
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
Part of #203.
The original issue is about adding a new konnect-related set of fields directly in the
DataPlaneAPI. I think we should be very cautious about this approach because KGO is an open-source project that aims to be used by Kong and Konnect customers AND community users. Including SaaS-related fields directly in the API would negatively affect the API itself form the community point of view. Hence this new extension CRD that with an approach very similar to theControlPlaneMetricsExtensionis intended to be used by the DataPlane controller to customize the DataPlane deployment with konnect-related configuration.Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes