Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(konnect): add generic reconciler scaffolding #446

Merged
merged 7 commits into from
Aug 1, 2024
Merged

feat(konnect): add generic reconciler scaffolding #446

merged 7 commits into from
Aug 1, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jul 30, 2024 •
edited
Loading

What this PR does / why we need it:

This PR adds generic reconciler scaffolding.

Which issue this PR fixes

Part of #437

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek added this to the KGO v1.4.x milestone Jul 30, 2024
@pmalek pmalek self-assigned this Jul 30, 2024
@pmalek pmalek force-pushed the konnect-generic-reconciler-scaffolding branch 2 times, most recently from bf98bad to af991bf Compare July 30, 2024 15:00
@pmalek pmalek marked this pull request as ready for review July 30, 2024 15:18
@pmalek pmalek requested a review from a team as a code owner July 30, 2024 15:18
@mlavacca mlavacca assigned mlavacca and unassigned mlavacca Jul 31, 2024
@mlavacca mlavacca self-requested a review July 31, 2024 10:38
@pmalek pmalek requested a review from czeslavo July 31, 2024 11:37
@pmalek pmalek mentioned this pull request Jul 31, 2024
Closed
1 task
@pmalek pmalek force-pushed the konnect-generic-reconciler-scaffolding branch from af991bf to 2e6cbdc Compare July 31, 2024 11:47
mlavacca
mlavacca reviewed Aug 1, 2024
View reviewed changes
controller/konnect/conditions.go Show resolved Hide resolved
controller/konnect/constraints.go Show resolved Hide resolved
controller/konnect/constraints.go Outdated Show resolved Hide resolved
controller/konnect/constraints.go Outdated Show resolved Hide resolved
controller/konnect/reconciler_generic.go Outdated Show resolved Hide resolved
controller/konnect/reconciler_generic.go Show resolved Hide resolved
@pmalek pmalek mentioned this pull request Aug 1, 2024
Closed
@pmalek pmalek force-pushed the konnect-generic-reconciler-scaffolding branch from 2f573bb to dbda5e5 Compare August 1, 2024 11:13
@pmalek pmalek requested a review from mlavacca August 1, 2024 11:18
@pmalek pmalek force-pushed the konnect-generic-reconciler-scaffolding branch from 541b3aa to 37442d7 Compare August 1, 2024 16:05
@pmalek pmalek merged commit 5e144db into main Aug 1, 2024
20 checks passed
@pmalek pmalek deleted the konnect-generic-reconciler-scaffolding branch August 1, 2024 16:51
@pmalek pmalek mentioned this pull request Aug 2, 2024
Open
2 tasks
@pmalek pmalek mentioned this pull request Aug 12, 2024
Closed
1 task
@pmalek pmalek linked an issue Aug 12, 2024 that may be closed by this pull request
Konnect entities: implement a generic reconciler scaffolding #437
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca mlavacca approved these changes

@czeslavo czeslavo Awaiting requested review from czeslavo

Assignees

@pmalek pmalek

Labels
area/konnect
Projects
None yet
Milestone
KGO v1.4.x
Development

Successfully merging this pull request may close these issues.

Konnect entities: implement a generic reconciler scaffolding
2 participants
@pmalek @mlavacca