feat: introduce basic reconciliation for KongPluginInstallation CRD #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
added
enhancement
programmer04
force-pushed
the
custom-plugin
branch
8 times, most recently
from
3d5a9a9 to
b7c5456
Compare
programmer04
force-pushed
the
custom-plugin
branch
7 times, most recently
from
9d08f69 to
7f3894a
Compare
mlavacca
reviewed
Aug 6, 2024
czeslavo
reviewed
Aug 6, 2024
programmer04
force-pushed
the
custom-plugin
branch
from
0fb167b to
c3cc195
Compare
1 task
programmer04
force-pushed
the
custom-plugin
branch
from
c3cc195 to
2186461
Compare
mlavacca
reviewed
Aug 7, 2024
programmer04
force-pushed
the
custom-plugin
branch
from
2186461 to
8ba2441
Compare
programmer04
force-pushed
the
custom-plugin
branch
3 times, most recently
from
60127db to
fa258f4
Compare
Co-authored-by: Mattia Lavacca <[email protected]>
Co-authored-by: Grzegorz Burzyński <[email protected]>
programmer04
force-pushed
the
custom-plugin
branch
from
fa258f4 to
746432d
Compare
czeslavo
approved these changes
Aug 9, 2024
mlavacca
approved these changes
Aug 9, 2024
1 task
pmalek
reviewed
Aug 12, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It introduces code for fetching and unpacking the content of container images that contain plugins. The expected format that will be documented is
also basic reconciliation of
KongPluginInstallationis introduced. A plugin is unpacked to a respectiveConfigMapand status conditions are set accordingly.Which issue this PR fixes
Closes #379
Special notes for your reviewer:
Tests verify the current state, they will evolve with time. Currently, integration tests don't focus on actual behavior, because it's not there yet. For now, it's better to have such a test than nothing.
It's not the final state, first of all, let's get functionality end to end, and next improve it.
I'm happy to make crucial improvements as part of this PR, for more minor/harder I'd rather create new tasks to do as a part of the Kong plugin distribution epic.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes