Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conformance): fix panic for make test.conformance #265

Merged
merged 1 commit into from
May 17, 2024

Conversation

programmer04
Copy link
Member

What this PR does / why we need it:

After

executing make conformance.tests

results in panic

GOTESTSUM_FORMAT=standard-verbose \
                /Users/[email protected]/Documents/work/gateway-operator/bin/installs/gotestsum/1.11.0/bin/gotestsum --  \
                -timeout "20m" \
                -race \
                -parallel 10 \
                ./test/conformance/...
/var/folders/v4/66lp8jy17r1_jx_2x0fv278w0000gn/T/go-build1021724069/b001/conformance.test flag redefined: debug
panic: /var/folders/v4/66lp8jy17r1_jx_2x0fv278w0000gn/T/go-build1021724069/b001/conformance.test flag redefined: debug

goroutine 1 [running]:
flag.(*FlagSet).Var(0xc000200150, {0x1064362c8, 0xc00012d12f}, {0x10555ea10, 0x5}, {0x105618608, 0x41})
        /opt/homebrew/Cellar/go/1.22.3/libexec/src/flag/flag.go:1028 +0x418
flag.(*FlagSet).BoolVar(...)
        /opt/homebrew/Cellar/go/1.22.3/libexec/src/flag/flag.go:749
flag.(*FlagSet).Bool(0xc000200150, {0x10555ea10, 0x5}, 0x0, {0x105618608, 0x41})
        /opt/homebrew/Cellar/go/1.22.3/libexec/src/flag/flag.go:762 +0x7c
flag.Bool(...)
        /opt/homebrew/Cellar/go/1.22.3/libexec/src/flag/flag.go:769
github.com/kong/gateway-operator/test/conformance.init()
        /Users/[email protected]/Documents/work/gateway-operator/test/conformance/conformance_test.go:37 +0x28c
FAIL    github.com/kong/gateway-operator/test/conformance       1.211s

=== Failed
=== FAIL: test/conformance  (0.00s)
/var/folders/v4/66lp8jy17r1_jx_2x0fv278w0000gn/T/go-build1021724069/b001/conformance.test flag redefined: debug
panic: /var/folders/v4/66lp8jy17r1_jx_2x0fv278w0000gn/T/go-build1021724069/b001/conformance.test flag redefined: debug

goroutine 1 [running]:
flag.(*FlagSet).Var(0xc000200150, {0x1064362c8, 0xc00012d12f}, {0x10555ea10, 0x5}, {0x105618608, 0x41})
        /opt/homebrew/Cellar/go/1.22.3/libexec/src/flag/flag.go:1028 +0x418
flag.(*FlagSet).BoolVar(...)
        /opt/homebrew/Cellar/go/1.22.3/libexec/src/flag/flag.go:749
flag.(*FlagSet).Bool(0xc000200150, {0x10555ea10, 0x5}, 0x0, {0x105618608, 0x41})
        /opt/homebrew/Cellar/go/1.22.3/libexec/src/flag/flag.go:762 +0x7c
flag.Bool(...)
        /opt/homebrew/Cellar/go/1.22.3/libexec/src/flag/flag.go:769
github.com/kong/gateway-operator/test/conformance.init()
        /Users/[email protected]/Documents/work/gateway-operator/test/conformance/conformance_test.go:37 +0x28c
FAIL    github.com/kong/gateway-operator/test/conformance       1.211s

DONE 0 tests, 1 failure in 6.622s
make[1]: *** [_test.conformance] Error 1
make: *** [test.conformance] Error 2

this PR brings it back to the state that they run, but fail

...
suite.go:348: 2024-05-16T17:59:21.406228+02:00: Test Setup: Ensuring Gateways and Pods from base manifests are ready
    helpers.go:217: 2024-05-16T17:59:21.417088+02:00: Gateway gateway-conformance-infra/all-namespaces expected observedGeneration to be updated to 1 for all conditions, only 3/4 were updated. stale conditions are: Programmed (generation 0)
    helpers.go:217: 2024-05-16T17:59:22.421528+02:00: Gateway gateway-conformance-infra/all-namespaces expected observedGeneration to be updated to 1 for all conditions, only 3/4 were updated. stale conditions are: Programmed (generation 0)
    helpers.go:217: 2024-05-16T17:59:23.41769+02:00: Gateway gateway-conformance-infra/all-namespaces expected observedGeneration to be updated to 1 for all conditions, only 3/4 were updated. stale conditions are: Programmed (generation 0)
    helpers.go:217: 2024-05-16T17:59:24.42362+02:00: Gateway gateway-conformance-infra/all-namespaces expected observedGeneration to be updated to 1 for all conditions, only 3/4 were updated. stale conditions are: Programmed (generation 0)
    helpers.go:217: 2024-05-16T17:59:25.418414+02:00: Gateway gateway-conformance-infra/all-namespaces expected observedGeneration to be updated to 1 for all conditions, only 3/4 were updated. stale conditions are: Programmed (generation 0)
    helpers.go:217: 2024-05-16T17:59:26.423449+02:00: Gateway gateway-conformance-infra/all-namespaces expected observedGeneration to be updated to 1 for all conditions, only 3/4 were updated. stale conditions are: Programmed (generation 0)
    ....

Fixing this failure will be handled in a separate PR.

Which issue this PR fixes

Part of #264

@programmer04 programmer04 added this to the KGO v1.3.x milestone May 16, 2024
@programmer04 programmer04 self-assigned this May 16, 2024
@programmer04 programmer04 requested a review from a team as a code owner May 16, 2024 16:06
@programmer04 programmer04 enabled auto-merge (squash) May 16, 2024 16:09
@programmer04 programmer04 force-pushed the conformance-fix-panic branch from 4c4491a to 34ab05b Compare May 17, 2024 15:16
@programmer04 programmer04 merged commit 7c90169 into main May 17, 2024
14 checks passed
@programmer04 programmer04 deleted the conformance-fix-panic branch May 17, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants