Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant dependency golang.org/x/net #1013

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Jan 14, 2025

@programmer04 programmer04 enabled auto-merge (squash) January 14, 2025 11:52
@pmalek
Copy link
Member

pmalek commented Jan 14, 2025

Maybe we introduce a simple script that will check for uses of "golang.org/x/net/context"?
Could be a simple bash script or something that parses the AST tree and checks the imports (if such a tool is not yet available)

@programmer04
Copy link
Member Author

Hmmm, maybe it was bad luck because this is the first time we have had such a problem. I don't recall fighting with it in the past, just bad timing and rolling a tool may be not worth it.

But contributing to gomodguard to overcome the limitation described in #1002 may be a nice little side quest that I may investigate in a spare time 😄

@pmalek
Copy link
Member

pmalek commented Jan 14, 2025

Hmmm, maybe it was bad luck because this is the first time we have had such a problem. I don't recall fighting with it in the past, just bad timing and rolling a tool may be not worth it.

But contributing to gomodguard to overcome the limitation described in #1002 may be a nice little side quest that I may investigate in a spare time 😄

I'll leave the decision to you but I believe a simple grep "golang.org/x/net/context" would suffice (at least for now).

@programmer04 programmer04 merged commit 229ac28 into main Jan 14, 2025
24 checks passed
@programmer04 programmer04 deleted the rm-redundant-deps branch January 14, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants