Skip to content

Commit

Permalink
chore: add comment about not supporting cross namespace references be…
Browse files Browse the repository at this point in the history
…tween KongRoute and KongService
  • Loading branch information
pmalek committed Oct 3, 2024
1 parent 27d765b commit ac6dd7b
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions controller/konnect/index_kongroute.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,8 @@ func kongRouteRefersToKongService(object client.Object) []string {
return nil
}

namespace := route.Namespace
if svcRef.NamespacedRef.Namespace != "" {
namespace = svcRef.NamespacedRef.Namespace
}
// NOTE: We currently do not allow cross namespace references between KongRoute and KongService.
// https://github.com/Kong/kubernetes-configuration/issues/106 tracks the implementation.

return []string{namespace + "/" + svcRef.NamespacedRef.Name}
return []string{route.Namespace + "/" + svcRef.NamespacedRef.Name}
}

0 comments on commit ac6dd7b

Please sign in to comment.