Apply suggestions from code review

Co-authored-by: Jakub Warczarek <[email protected]>
Kong · Oct 8, 2024 · 30511b8 · 30511b8
1 parent 71f4f3d
commit 30511b8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/controller/gateway/controller_watch.go b/controller/gateway/controller_watch.go
@@ -228,8 +228,7 @@ func (r *Reconciler) listManagedGatewaysInNamespace(ctx context.Context, obj cli
 	for _, gateway := range gateways.Items {
 		objKey := client.ObjectKey{Name: string(gateway.Spec.GatewayClassName)}
 
-		_, err := gatewayclass.Get(ctx, r.Client, string(gateway.Spec.GatewayClassName))
-		if err != nil {
+		if _, err := gatewayclass.Get(ctx, r.Client, string(gateway.Spec.GatewayClassName)); err != nil {
 			if errors.As(err, &operatorerrors.ErrUnsupportedGatewayClass{}) {
 				log.Debug(logger, "gateway class not supported, ignoring", gateway)
 			} else {

diff --git a/internal/errors/errors.go b/internal/errors/errors.go
@@ -28,7 +28,7 @@ func NewErrUnsupportedGateway(reason string) ErrUnsupportedGatewayClass {
 }
 
 func (e ErrUnsupportedGatewayClass) Error() string {
-	return fmt.Errorf("unsupported gateway class: %s", e.reason).Error()
+	return fmt.Sprintf("unsupported gateway class: %s", e.reason)
 }
 
 // -----------------------------------------------------------------------------