Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIC: feat: add introduction about combined service from different httproutes #8270

Merged
merged 5 commits into from
Dec 19, 2024
Merged

KIC: feat: add introduction about combined service from different httproutes #8270

merged 5 commits into from
Dec 19, 2024

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Dec 16, 2024 •
edited
Loading

Description

Add introduction of feature CombinedServicesFromDifferentHTTPRoutes in feature gate page and a new reference page.
fixes #8216.

Testing instructions

Preview link:

Checklist

@randmonkey randmonkey added team-k8s Kubernetes task tracking (including KIC,KGO) review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? labels Dec 16, 2024
@randmonkey randmonkey added this to the KIC v3.4.x milestone Dec 16, 2024
@randmonkey randmonkey requested a review from a team as a code owner December 16, 2024 09:52
@netlify Netlify
Copy link

netlify bot commented Dec 16, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit a180978
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/67641acc29746a00081eb0f8
😎 Deploy Preview https://deploy-preview-8270--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 91 (🔴 down 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@randmonkey randmonkey force-pushed the kic/combined_service_httproute branch 2 times, most recently from facaf02 to ad0863c Compare December 16, 2024 10:17
@randmonkey randmonkey closed this Dec 18, 2024
@randmonkey randmonkey reopened this Dec 18, 2024
@randmonkey randmonkey force-pushed the kic/combined_service_httproute branch from d17b879 to b260e39 Compare December 18, 2024 09:42
lahabana
lahabana reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! I've got a few suggestions which may help readability

app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/feature-gates.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/feature-gates.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Show resolved Hide resolved
@randmonkey randmonkey force-pushed the kic/combined_service_httproute branch from a033032 to 9b627ec Compare December 19, 2024 02:46
@randmonkey randmonkey force-pushed the kic/combined_service_httproute branch from 9b627ec to 10dc9d5 Compare December 19, 2024 02:51
lahabana
lahabana reviewed Dec 19, 2024
View reviewed changes
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/feature-gates.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/feature-gates.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/feature-gates.md Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/feature-gates.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/feature-gates.md Outdated Show resolved Hide resolved
@randmonkey randmonkey requested a review from lahabana December 19, 2024 12:34
lahabana
lahabana approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small nits so proactively approving this

app/_data/docs_nav_kic_3.4.x.yml Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/reference/combined-services-from-different-httproutes.md Outdated Show resolved Hide resolved
@Guaris Guaris merged commit f3a0ce3 into main Dec 19, 2024
15 checks passed
@Guaris Guaris deleted the kic/combined_service_httproute branch December 19, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guaris Guaris Guaris approved these changes

@lahabana lahabana lahabana approved these changes

@programmer04 programmer04 Awaiting requested review from programmer04

Assignees
No one assigned
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? team-k8s Kubernetes task tracking (including KIC,KGO)
Projects
None yet
Milestone
KIC v3.4.x
Development

Successfully merging this pull request may close these issues.

Document works about the feature gate and changes in translated server name
4 participants
@randmonkey @lahabana @programmer04 @Guaris