Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Consumer groups docs #8257

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Fix: Consumer groups docs #8257

merged 4 commits into from
Dec 13, 2024

Conversation

lena-larionova
Copy link
Contributor

@lena-larionova lena-larionova commented Dec 13, 2024

Description

Addressing feedback we’ve received on consumer groups docs, where some of the docs are outdated (kong manager), one is missing from the nav but findable via search (Konnect), and links for how-to guides go to the Rate Limiting plugin, which is only one of the plugins that supports consumer groups.

  • The Kong Manager topic is very short and doesn't need to exist, but doesn't hurt to leave it for now
  • The Konnect topic is a condensed version of upcoming how-to guides
  • As part of this, splitting out the Personal Access Token info into its own doc, as we link to it a bunch (I needed to from the consumer groups doc), but its buried in a decK page.

Fixes #6465 and https://konghq.atlassian.net/browse/DOCU-3593

Testing instructions

Preview link:
https://deploy-preview-8257--kongdocs.netlify.app/gateway/latest/key-concepts/consumer-groups/
https://deploy-preview-8257--kongdocs.netlify.app/gateway/latest/kong-manager/consumer-groups/
https://deploy-preview-8257--kongdocs.netlify.app/konnect/gateway-manager/configuration/consumer-groups/
https://deploy-preview-8257--kongdocs.netlify.app/konnect/org-management/access-tokens/

Checklist

@lena-larionova lena-larionova added the review:copyedit Request for writer review. label Dec 13, 2024
@lena-larionova lena-larionova requested a review from a team as a code owner December 13, 2024 06:05
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 12c3865
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/675ca2e4eedf68000718c77e
😎 Deploy Preview https://deploy-preview-8257--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93 (🟢 up 3 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple suggestions, but I'll approve so you aren't blocked!

@lena-larionova lena-larionova merged commit 44a62e6 into main Dec 13, 2024
15 checks passed
@lena-larionova lena-larionova deleted the fix/consumer-groups-docs branch December 13, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:copyedit Request for writer review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Create Consumer Groups' subpage leads to 'How to create rate limiting tiers'
2 participants