Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use prereq styling for KIC and KGO #8180

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

lena-larionova
Copy link
Contributor

@lena-larionova lena-larionova commented Nov 27, 2024

Description

We've gotten multiple reports from users that they can't tell that the KIC and KGO prereq notes are supposed to be clickable & expandable. Changing these notes to use the styling that we use for the plugins.

Had to shorten the prereqs to be more concise, but they still look a bit weird. This styling is really not meant for full sentences. At the same time, I don't want to put anymore time into this, as this is temporary anyway.

https://konghq.atlassian.net/browse/DOCU-4124

Testing instructions

Preview links for example pages:
https://deploy-preview-8180--kongdocs.netlify.app/kubernetes-ingress-controller/latest/guides/services/http/
https://deploy-preview-8180--kongdocs.netlify.app/gateway-operator/latest/guides/plugin-distribution/

Checklist

@lena-larionova lena-larionova added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Nov 27, 2024
@lena-larionova lena-larionova requested a review from a team as a code owner November 27, 2024 01:05
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit bb715a2
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/6746703ecc81fa0008903a5e
😎 Deploy Preview https://deploy-preview-8180--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 92 (🟢 up 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lena-larionova lena-larionova merged commit 0ed061c into main Dec 2, 2024
21 checks passed
@lena-larionova lena-larionova deleted the fix/docu-4124 branch December 2, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants