bug-bash: Change phase to directive in custom logic doc #8001
Conversation
Guaris
added
the
review:general
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -42,7 +42,7 @@ of {{site.base_gateway}}'s execution life-cycle: | |||
| - **[HTTP Module]** *is used for plugins written for HTTP/HTTPS requests* | |||
| {% if_version lte: 3.3.x %} | |||
|
|
|||
| | Function name | Phase | Request Protocol | Description | |||
| | Function name | Directive | Request Protocol | Description | |||
There was a problem hiding this comment.
I think it's a bit more complicated than this. The items in this column cover both a phase and a directive. Check out the diagram here: https://github.com/openresty/lua-nginx-module?tab=readme-ov-file#directives.
As the reporter points out in the GH issue,
- "rewrite" in Kong -> stands for the "rewrite tail" phase and the "rewrite_by_lua_*" directive: https://github.com/openresty/lua-nginx-module#rewrite_by_lua_block
It looks like what we're actually missing is another column, which details what the directive is. So for rewrite, you get:
Function: rewrite
Phase: rewrite tail
Directives: rewrite_by_lua_*
There was a problem hiding this comment.
This is missing the second part of the issue as well, which is:
An other issue concerns the "reponse" function, for which the phase is "access". However, according to the description, it replaces "header_filter()" and "body_filter()". As shown in the diagram in the Directives section, they are part of "Content Phase", not "Access Phase". This seems to be a mistake.
Fixes #7533