Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Azure Vnet peering for Cloud Gateways #7870

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Feat: Azure Vnet peering for Cloud Gateways #7870

merged 8 commits into from
Sep 11, 2024

Conversation

Guaris
Copy link
Contributor

@Guaris Guaris commented Sep 6, 2024

@Guaris Guaris added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Sep 6, 2024
@Guaris Guaris requested a review from a team as a code owner September 6, 2024 21:40
@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 74dca4d
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66e0ea64a4ef7a0008ecd7c1
😎 Deploy Preview https://deploy-preview-7870--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 91 (no change from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudjumpercat
cloudjumpercat requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments and a few questions/suggestions about adding more info about a few things. Let me know if you have any questions!

app/_includes/md/konnect/azure-peering.md Show resolved Hide resolved
app/konnect/gateway-manager/data-plane-nodes/azure-peering.md Outdated Show resolved Hide resolved
app/konnect/gateway-manager/data-plane-nodes/azure-peering.md Outdated Show resolved Hide resolved
app/konnect/gateway-manager/data-plane-nodes/azure-peering.md Outdated Show resolved Hide resolved
app/konnect/gateway-manager/data-plane-nodes/azure-peering.md Outdated Show resolved Hide resolved
app/konnect/gateway-manager/data-plane-nodes/azure-peering.md Outdated Show resolved Hide resolved
app/konnect/gateway-manager/data-plane-nodes/azure-peering.md Outdated Show resolved Hide resolved
app/konnect/gateway-manager/data-plane-nodes/azure-peering.md Outdated Show resolved Hide resolved
app/konnect/gateway-manager/data-plane-nodes/azure-peering.md Outdated Show resolved Hide resolved
app/konnect/gateway-manager/data-plane-nodes/azure-peering.md Outdated Show resolved Hide resolved
Guaris and others added 2 commits September 10, 2024 12:57
cloudjumpercat
cloudjumpercat approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few very small nitpicks, everything else is good!

app/konnect/gateway-manager/data-plane-nodes/azure-peering.md Outdated Show resolved Hide resolved
app/konnect/gateway-manager/data-plane-nodes/azure-peering.md Outdated Show resolved Hide resolved
prateekguptagh
prateekguptagh requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@prateekguptagh prateekguptagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs \ as it is a multiline command

app/konnect/gateway-manager/data-plane-nodes/azure-peering.md Outdated Show resolved Hide resolved
@Guaris Guaris self-assigned this Sep 11, 2024
@Guaris Guaris added this to the Gateway 3.8 milestone Sep 11, 2024
@Guaris Guaris merged commit 10dcd74 into main Sep 11, 2024
15 checks passed
@Guaris Guaris deleted the DOCU-4041 branch September 11, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudjumpercat cloudjumpercat cloudjumpercat approved these changes

@prateekguptagh prateekguptagh prateekguptagh approved these changes

Assignees

@Guaris Guaris

Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Milestone
Gateway 3.8
Development

Successfully merging this pull request may close these issues.
3 participants
@Guaris @prateekguptagh @cloudjumpercat