Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AWS configurable STS endpoint for assume role #7869

Closed
wants to merge 1 commit into from

Conversation

cloudjumpercat
Copy link
Contributor

Description

Added more info about the two new config options that allow you to configure an AWS STS endpoint URL.

DOCU-4058

Testing instructions

Preview link:

Checklist

@cloudjumpercat cloudjumpercat added the review:copyedit Request for writer review. label Sep 6, 2024
@cloudjumpercat cloudjumpercat added this to the Gateway 3.8 milestone Sep 6, 2024
@cloudjumpercat cloudjumpercat requested a review from a team as a code owner September 6, 2024 20:14
Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit bf08743
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66db62be0ae2360008530f45
😎 Deploy Preview https://deploy-preview-7869--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 92 (🟢 up 3 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudjumpercat
Copy link
Contributor Author

@windmgc Hi! I saw that you worked on the AWS STS endpoint URL feature for 3.8. I was wondering if you could look over the changes I made to docs to support this feature and just check that everything looks correct and I didn't miss anything? I wasn't sure if this feature needed a separate section in the AWS Secrets Manager page. Thanks!

Copy link
Member

@windmgc windmgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cloudjumpercat ! The content looks good to me overall, leaving a few comments

Actually, I have already raised another PR #7762 weeks ago, do you want to also include my part of that configuration example in the app/_src/gateway/kong-enterprise/aws-iam-auth-to-rds-database.md?

| `vaults.config.resurrect_ttl` | **Resurrect TTL** | Time (in seconds) for how long secrets will remain in use after they are expired ( using `config.ttl` as the stopping point). This is useful when a vault becomes unreachable, or when a secret is deleted from the vault and isn't replaced immediately. In both cases, gateway will keep trying to refresh the secret for `resurrect_ttl` seconds. After that, it will stop trying to refresh. Assigning a sufficiently high value to this configuration option is recommended to ensure a seamless transition in case there are unexpected issues with the vault. The default value for `resurrect_ttl` is 1^e8 seconds, which is about 3 years. |

{% if_version gte:3.8.x %}
| `vaults.config.aws_sts_endpoint_url` | **Global Config STS Endpoint** | A configurable STS endpoint for AWS Vault that is used as a global configuration. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `vaults.config.aws_sts_endpoint_url` | **Global Config STS Endpoint** | A configurable STS endpoint for AWS Vault that is used as a global configuration. |

Copy link
Member

@windmgc windmgc Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vaults.config.sts_endpoint_url should be the correct one, vault.config.aws_sts_endpoint_url does not exist in the vault entity schema, so it should be removed

@@ -37,7 +37,8 @@ Before you enable the AWS IAM authentication, you must configure your AWS RDS da
{:.warning}
> **Warning:** You **can't** change the value of the environment variables you used to provide the AWS credential after booting {{site.base_gateway}}. Any changes are ignored.
{% if_version gte:3.8.x %}
- If you want to assume a role, make sure the original IAM role that Kong uses has the correct permission to assume the role of the target IAM role, and the target IAM role has the correct permission to connect to the database using IAM authentication.
- If you want to assume a role, make sure the original IAM role that Kong uses has the correct permission to assume the role of the target IAM role, and the target IAM role has the correct permission to connect to the database using IAM authentication.
- If you have users with non-public VPC networks and private VPC endpoints (without private DNS names enabled), you can configure a AWS Service Token Service (STS) globally with `vault_aws_sts_endpoint_url` or on a custom AWS Vault entity with `sts_endpoint_url`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- If you have users with non-public VPC networks and private VPC endpoints (without private DNS names enabled), you can configure a AWS Service Token Service (STS) globally with `vault_aws_sts_endpoint_url` or on a custom AWS Vault entity with `sts_endpoint_url`.
- If you have users with non-public VPC networks and private VPC endpoints (without private DNS names enabled), you can configure an AWS Service Token Service (STS) endpoint globally with `vault_aws_sts_endpoint_url` or on a custom AWS Vault entity with `sts_endpoint_url`.

@cloudjumpercat
Copy link
Contributor Author

Closing this PR in favor of #7762 (I didn't know there was already an open PR). I've added my relevant changes to that PR along with the feedback from Keery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:copyedit Request for writer review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants