-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service Catalog: teams and roles #7849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guaris
added
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
review:copyedit
Request for writer review.
labels
Sep 4, 2024
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lena-larionova
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of minor edits but otherwise LGTM
Co-authored-by: lena-larionova <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
Guaris
added a commit
that referenced
this pull request
Sep 10, 2024
* teams and roles * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * Update app/konnect/org-management/teams-and-roles/roles-reference.md Co-authored-by: lena-larionova <[email protected]> --------- Co-authored-by: lena-larionova <[email protected]>
Merged
miko-bautista
pushed a commit
that referenced
this pull request
Sep 11, 2024
* feat: Service Catalog landing page (#7739) * Add sections and content (that needs to be paired down) Signed-off-by: Diana <[email protected]> * Revise intro paragraph and terminology table, also placeholder for FAQ and diagrams Signed-off-by: Diana <[email protected]> * Finish draft of Service Catalog overview and appease Vale Signed-off-by: Diana <[email protected]> * Improve the Service Catalog diagram Signed-off-by: Diana <[email protected]> * Apply Miko's feedback Signed-off-by: Diana <[email protected]> * Appease Vale Signed-off-by: Diana <[email protected]> * Fix related info link text Signed-off-by: Diana <[email protected]> * Apply suggestions from code review Co-authored-by: Angel <[email protected]> * Apply more feedback like making a use case table Signed-off-by: Diana <[email protected]> * Apply more feedback, fix expander menus Signed-off-by: Diana <[email protected]> * Small fixes Signed-off-by: Diana <[email protected]> * Fix naming of Service Catalog service and Gateway service Signed-off-by: Diana <[email protected]> * Generalize the integrations/resources in the diagram, fix diagram styling, apply Miko's feedback Signed-off-by: Diana <[email protected]> * Apply suggestions from code review to improve diagram Co-authored-by: lena-larionova <[email protected]> --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Angel <[email protected]> Co-authored-by: lena-larionova <[email protected]> * Service Catalog: teams and roles (#7849) * teams and roles * Apply suggestions from code review Co-authored-by: lena-larionova <[email protected]> * Update app/konnect/org-management/teams-and-roles/roles-reference.md Co-authored-by: lena-larionova <[email protected]> --------- Co-authored-by: lena-larionova <[email protected]> * feat: Service Catalog Integrations landing page (#7862) * integrations landing page * drafts for integrations * github, traceable, pagerduty * fix icons + replace with smaller icons; clean up * add bindable to dictionary * create include for discovery info --------- Co-authored-by: Angel <[email protected]> * Apply suggestions from code review * Apply suggestions from code review * fix include * vale * Update app/konnect/service-catalog/integrations/traceable.md Co-authored-by: lena-larionova <[email protected]> --------- Signed-off-by: Diana <[email protected]> Co-authored-by: Diana <[email protected]> Co-authored-by: lena-larionova <[email protected]> Co-authored-by: lena-larionova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
review:copyedit
Request for writer review.
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://konghq.atlassian.net/browse/DOCU-3995