Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Catalog: teams and roles #7849

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Service Catalog: teams and roles #7849

merged 3 commits into from
Sep 10, 2024

Conversation

Guaris
Copy link
Contributor

@Guaris Guaris commented Sep 4, 2024

@Guaris Guaris added review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:copyedit Request for writer review. labels Sep 4, 2024
@Guaris Guaris requested a review from a team as a code owner September 4, 2024 19:59
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 4ad7ad2
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66e0b5c5903be200093108c7
😎 Deploy Preview https://deploy-preview-7849--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93 (🟢 up 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor edits but otherwise LGTM

@Guaris Guaris merged commit 617447a into feat/service-catalog Sep 10, 2024
14 of 15 checks passed
@Guaris Guaris deleted the DOCU-3995 branch September 10, 2024 21:12
Guaris added a commit that referenced this pull request Sep 10, 2024
* teams and roles

* Apply suggestions from code review

Co-authored-by: lena-larionova <[email protected]>

* Update app/konnect/org-management/teams-and-roles/roles-reference.md

Co-authored-by: lena-larionova <[email protected]>

---------

Co-authored-by: lena-larionova <[email protected]>
miko-bautista pushed a commit that referenced this pull request Sep 11, 2024
* feat: Service Catalog landing page (#7739)

* Add sections and content (that needs to be paired down)

Signed-off-by: Diana <[email protected]>

* Revise intro paragraph and terminology table, also placeholder for FAQ and diagrams

Signed-off-by: Diana <[email protected]>

* Finish draft of Service Catalog overview and appease Vale

Signed-off-by: Diana <[email protected]>

* Improve the Service Catalog diagram

Signed-off-by: Diana <[email protected]>

* Apply Miko's feedback

Signed-off-by: Diana <[email protected]>

* Appease Vale

Signed-off-by: Diana <[email protected]>

* Fix related info link text

Signed-off-by: Diana <[email protected]>

* Apply suggestions from code review

Co-authored-by: Angel <[email protected]>

* Apply more feedback like making a use case table

Signed-off-by: Diana <[email protected]>

* Apply more feedback, fix expander menus

Signed-off-by: Diana <[email protected]>

* Small fixes

Signed-off-by: Diana <[email protected]>

* Fix naming of Service Catalog service and Gateway service

Signed-off-by: Diana <[email protected]>

* Generalize the integrations/resources in the diagram, fix diagram styling, apply Miko's feedback

Signed-off-by: Diana <[email protected]>

* Apply suggestions from code review to improve diagram

Co-authored-by: lena-larionova <[email protected]>

---------

Signed-off-by: Diana <[email protected]>
Co-authored-by: Angel <[email protected]>
Co-authored-by: lena-larionova <[email protected]>

* Service Catalog: teams and roles (#7849)

* teams and roles

* Apply suggestions from code review

Co-authored-by: lena-larionova <[email protected]>

* Update app/konnect/org-management/teams-and-roles/roles-reference.md

Co-authored-by: lena-larionova <[email protected]>

---------

Co-authored-by: lena-larionova <[email protected]>

* feat: Service Catalog Integrations landing page (#7862)

* integrations landing page

* drafts for integrations

* github, traceable, pagerduty

* fix icons + replace with smaller icons; clean up

* add bindable to dictionary

* create include for discovery info

---------

Co-authored-by: Angel <[email protected]>

* Apply suggestions from code review

* Apply suggestions from code review

* fix include

* vale

* Update app/konnect/service-catalog/integrations/traceable.md

Co-authored-by: lena-larionova <[email protected]>

---------

Signed-off-by: Diana <[email protected]>
Co-authored-by: Diana <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:copyedit Request for writer review. review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants