Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update Cloud Gateways geos #7832

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Chore: Update Cloud Gateways geos #7832

merged 3 commits into from
Sep 11, 2024

Conversation

Guaris
Copy link
Contributor

@Guaris Guaris commented Sep 3, 2024

@Guaris Guaris added review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? skip-changelog labels Sep 3, 2024
@Guaris Guaris requested a review from a team as a code owner September 3, 2024 20:25
@netlify Netlify
Copy link

netlify bot commented Sep 3, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit f1c0de4
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66d86b290765060008856816
😎 Deploy Preview https://deploy-preview-7832--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 92 (🟢 up 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Guaris Guaris added the do not merge Issues/ PRs whose changes should not be merged at this time label Sep 3, 2024
@Guaris Guaris marked this pull request as draft September 3, 2024 20:28
lena-larionova
lena-larionova approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment, you can decide what you want to do with that.

@Guaris Guaris self-assigned this Sep 11, 2024
@Guaris Guaris added this to the Gateway 3.8 milestone Sep 11, 2024
@Guaris Guaris marked this pull request as ready for review September 11, 2024 01:25
@Guaris Guaris removed the do not merge Issues/ PRs whose changes should not be merged at this time label Sep 11, 2024
@Guaris Guaris merged commit d09ea53 into main Sep 11, 2024
28 checks passed
@Guaris Guaris deleted the DOCU-4051 branch September 11, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lena-larionova lena-larionova lena-larionova approved these changes

Assignees

@Guaris Guaris

Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? skip-changelog
Projects
None yet
Milestone
Gateway 3.8
Development

Successfully merging this pull request may close these issues.
2 participants
@Guaris @lena-larionova