chore: 3.8 breaking changes #7818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diana <[email protected]>
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cloudjumpercat
commented
Aug 29, 2024
Comment on lines
34
to
42
|
|
||
| The following plugins switched `cluster_addresses` to `cluster_nodes` and `sentinel_addresses` to `sentinel_nodes` for Redis configuration: | ||
|
|
||
| * [AI Rate Limiting Advanced](/hub/kong-inc/ai-rate-limiting-advanced/) | ||
| * [GraphQL Proxy Caching Advanced](/hub/kong-inc/graphql-proxy-cache-advanced/) | ||
| * [GraphQL Rate Limiting Advanced](/hub/kong-inc/graphql-rate-limiting-advanced/) | ||
| * [Proxy Caching Advanced](/hub/kong-inc/proxy-cache-advanced/) | ||
| * [Rate Limiting Advanced](/hub/kong-inc/rate-limiting-advanced/) |
There was a problem hiding this comment.
Hi @jschmid1 ! I'm writing a doc that compiles the 3.8 breaking changes and I had a question about the sentinel_addresses and cluster_addresses for Redis feature changes you made. Are these converted automatically with 3.8 or does the user have to manually migrate or change anything? Thanks!
Signed-off-by: Diana <[email protected]>
2 tasks
| ### Custom plugins that used shared Redis config | ||
|
|
||
| In 3.8.0.0, Kong has changed and refactored the shared Redis configuration that previously was imported by `require "kong.enterprise_edition.redis"`. If you created a custom plugin that is using this shared configuration or if you have a forked versionof a plugin, like `rate-limiting-advanced`, then you might need to do additional steps before you can upgrade to the new version of this Redis config. |
There was a problem hiding this comment.
Suggested change
| In 3.8.0.0, Kong has changed and refactored the shared Redis configuration that previously was imported by `require "kong.enterprise_edition.redis"`. If you created a custom plugin that is using this shared configuration or if you have a forked versionof a plugin, like `rate-limiting-advanced`, then you might need to do additional steps before you can upgrade to the new version of this Redis config. | |
| In 3.8.0.0, Kong has changed and refactored the shared Redis configuration that previously was imported by `require "kong.enterprise_edition.redis"`. If you created a custom plugin that is using this shared configuration or if you have a forked version of a plugin, like `rate-limiting-advanced`, then you might need to do additional steps before you can upgrade to the new version of this Redis config. |
| In 3.8.0.0, Kong has changed and refactored the shared Redis configuration that previously was imported by `require "kong.enterprise_edition.redis"`. If you created a custom plugin that is using this shared configuration or if you have a forked versionof a plugin, like `rate-limiting-advanced`, then you might need to do additional steps before you can upgrade to the new version of this Redis config. | ||
|
|
||
| Out-of-the-box the custom plugins should still work since the old shared configuration was left in place. The new config adds the `cluster_max_redirections` option for Redis Cluster, and the `cluster_nodes` format and |
There was a problem hiding this comment.
Suggested change
| Out-of-the-box the custom plugins should still work since the old shared configuration was left in place. The new config adds the `cluster_max_redirections` option for Redis Cluster, and the `cluster_nodes` format and | |
| Out of the box, custom plugins should still work since the old shared configuration is still available. The new config adds the `cluster_max_redirections` option for Redis Cluster, and the `cluster_nodes` format and |
Signed-off-by: Diana <[email protected]>
lena-larionova
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added 3.8 breaking changes (or what I thought were) from the changelog to the doc.
DOCU-4038
Testing instructions
Preview link:
Checklist