Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: New DNS client for Gateway 3.8 #7805

Merged
merged 10 commits into from
Sep 10, 2024
Merged

Feat: New DNS client for Gateway 3.8 #7805

merged 10 commits into from
Sep 10, 2024

Conversation

lmilan
Copy link
Contributor

@lmilan lmilan commented Aug 28, 2024 •
edited
Loading

Description

Documented migration to new DNS client.

https://konghq.atlassian.net/browse/DOCU-4021

Testing instructions

Preview links:

Checklist

@lmilan lmilan added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Aug 28, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 28, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 89772d7
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66deb1699253c500081fec23
😎 Deploy Preview https://deploy-preview-7805--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 91 (no change from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lena-larionova lena-larionova added this to the Gateway 3.8 milestone Aug 30, 2024
@lmilan lmilan marked this pull request as ready for review September 2, 2024 07:51
@lmilan lmilan requested a review from a team as a code owner September 2, 2024 07:51
chobits
chobits approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@chobits chobits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the content, and think it as expected. (also reference to my original migration guide

Guaris
Guaris reviewed Sep 3, 2024
View reviewed changes
app/_src/gateway/migrate-to-new-dns-client.md Outdated Show resolved Hide resolved
app/_src/gateway/migrate-to-new-dns-client.md Outdated Show resolved Hide resolved
app/_src/gateway/migrate-to-new-dns-client.md Outdated Show resolved Hide resolved
teb510
teb510 reviewed Sep 4, 2024
View reviewed changes
app/_src/gateway/migrate-to-new-dns-client.md Outdated Show resolved Hide resolved
app/_src/gateway/migrate-to-new-dns-client.md Outdated Show resolved Hide resolved
app/_src/gateway/production/performance/benchmark.md Outdated Show resolved Hide resolved
app/_src/gateway/migrate-to-new-dns-client.md Outdated Show resolved Hide resolved
@lmilan lmilan self-assigned this Sep 9, 2024
@Guaris Guaris self-requested a review September 9, 2024 16:45
@lmilan lmilan merged commit 765ba6b into main Sep 10, 2024
15 checks passed
@lmilan lmilan deleted the DOCU-4021 branch September 10, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudjumpercat cloudjumpercat cloudjumpercat left review comments

@teb510 teb510 teb510 left review comments

@chobits chobits chobits approved these changes

@Guaris Guaris Guaris approved these changes

Assignees

@lmilan lmilan

Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Milestone
Gateway 3.8
Development

Successfully merging this pull request may close these issues.
6 participants
@lmilan @chobits @Guaris @teb510 @cloudjumpercat @lena-larionova