Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: PDK and CLI docs for Gateway 3.8 #7786

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Chore: PDK and CLI docs for Gateway 3.8 #7786

merged 2 commits into from
Sep 4, 2024

Conversation

Guaris
Copy link
Contributor

@Guaris Guaris commented Aug 23, 2024

@Guaris Guaris added review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? ci:check-skipped:generated-files skip-changelog labels Aug 23, 2024
@Guaris Guaris added this to the Gateway 3.8 milestone Aug 23, 2024
@Guaris Guaris requested a review from a team as a code owner August 23, 2024 13:11
@netlify Netlify
Copy link

netlify bot commented Aug 23, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit ca16262
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66c88a9386c557000851b4a8
😎 Deploy Preview https://deploy-preview-7786--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 91 (🟢 up 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ This PR edits generated files. Please make sure that the source file is updated.

https://github.com/Kong/kong/tree/master/kong/pdk/client.lua:

  • app/_src/gateway/plugin-development/pdk/kong.client.md

https://github.com/Kong/kong/tree/master/kong/pdk/client/tls.lua:

  • app/_src/gateway/plugin-development/pdk/kong.client.tls.md

https://github.com/Kong/kong/tree/master/kong/pdk/request.lua:

  • app/_src/gateway/plugin-development/pdk/kong.request.md

https://github.com/Kong/kong/tree/master/kong/pdk/service.lua:

  • app/_src/gateway/plugin-development/pdk/kong.service.md

https://github.com/Kong/kong/tree/master/kong/pdk/service/request.lua:

  • app/_src/gateway/plugin-development/pdk/kong.service.request.md

https://github.com/Kong/kong/tree/master/kong/pdk/telemetry.lua:

  • app/_src/gateway/plugin-development/pdk/kong.telemetry.log.md

https://github.com/Kong/kong/tree/master/kong/cmd:

  • app/_src/gateway/reference/cli.md

lena-larionova
lena-larionova approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this contains everything I saw in the changelog.

@Guaris Guaris merged commit e564f34 into main Sep 4, 2024
45 of 46 checks passed
@Guaris Guaris deleted the autodocs-3.8 branch September 4, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lena-larionova lena-larionova lena-larionova approved these changes

Assignees
No one assigned
Labels
ci:manual-approve:generated-files review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? skip-changelog
Projects
None yet
Milestone
Gateway 3.8
Development

Successfully merging this pull request may close these issues.
2 participants
@Guaris @lena-larionova