Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Header Cert Auth plugin #7775

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Feat: Header Cert Auth plugin #7775

merged 9 commits into from
Sep 9, 2024

Conversation

lena-larionova
Copy link
Contributor

@lena-larionova lena-larionova commented Aug 21, 2024

Description

Doc for new Header Cert Auth plugin.
https://konghq.atlassian.net/browse/DOCU-4005

Schema and basic example added in Kong/docs-plugin-toolkit#46.
Based on https://github.com/Kong/kong-ee/pull/9723.

Testing instructions

Preview link: https://deploy-preview-7775--kongdocs.netlify.app/hub/kong-inc/header-cert-auth/unreleased/

Checklist

@lena-larionova lena-larionova added the review:sme Request for SME review, external to the docs team. label Aug 21, 2024
@lena-larionova lena-larionova added this to the Gateway 3.8 milestone Aug 21, 2024
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 10e9145
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66da473dedebba0008491d26
😎 Deploy Preview https://deploy-preview-7775--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 91 (🟢 up 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@gruceo gruceo force-pushed the feat/header-cert-auth branch from 8af4f2b to acf3f52 Compare August 26, 2024 22:18
@gruceo gruceo requested a review from veenaraja August 26, 2024 22:20
@gruceo gruceo marked this pull request as ready for review August 26, 2024 22:20
@gruceo gruceo requested a review from a team as a code owner August 26, 2024 22:20
@gruceo
Copy link
Contributor

gruceo commented Aug 27, 2024

Hi @lena-larionova last two comments in KAG-4800 will add very good value to customers. We should add it to the AWS ALB integration guide. We have screenshots, command snippets and logs that shows how to setup this plugin to work with AWS. What's the best way to document this kind of usage? Any examples, guidelines would be helpful.

Copy link
Contributor

@veenaraja veenaraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I did not see an example or a sample of how request from aws waf would look like.

Would be good to show what base64-encoded and url-encoded looks like - even if it is a curl example

@gruceo gruceo force-pushed the feat/header-cert-auth branch 3 times, most recently from 81ee00b to f51477f Compare September 2, 2024 17:52
@gruceo
Copy link
Contributor

gruceo commented Sep 2, 2024

@veenaraja done, added AWS docs.

@gruceo gruceo force-pushed the feat/header-cert-auth branch from f51477f to 8f01da2 Compare September 2, 2024 19:01
@lena-larionova lena-larionova added review:copyedit Request for writer review. and removed review:sme Request for SME review, external to the docs team. labels Sep 4, 2024
@lena-larionova lena-larionova merged commit de65ee6 into main Sep 9, 2024
15 checks passed
@lena-larionova lena-larionova deleted the feat/header-cert-auth branch September 9, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:copyedit Request for writer review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants