Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: decK select tag examples #7735

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Fix: decK select tag examples #7735

merged 1 commit into from
Aug 8, 2024

Conversation

lena-larionova
Copy link
Contributor

Description

Fixing the select-tag examples in the decK docs to match real behavior.

https://konghq.atlassian.net/browse/DOCU-4012

Testing instructions

Preview link:

Checklist

@lena-larionova lena-larionova added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Aug 7, 2024
@lena-larionova lena-larionova requested a review from a team as a code owner August 7, 2024 20:26
@netlify Netlify
Copy link

netlify bot commented Aug 7, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 2df7b7b
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/66b3d890d8e6510008a9d037
😎 Deploy Preview https://deploy-preview-7735--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 92 (🟢 up 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudjumpercat
cloudjumpercat approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lena-larionova lena-larionova merged commit 316da66 into main Aug 8, 2024
21 checks passed
@lena-larionova lena-larionova deleted the fix/deck-select-tag branch August 8, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudjumpercat cloudjumpercat cloudjumpercat approved these changes

Assignees
No one assigned
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lena-larionova @cloudjumpercat