Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Patryk Małek <[email protected]>
  • Loading branch information
randmonkey and pmalek authored Dec 20, 2024
1 parent 4005f90 commit 3e4f1ec
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions app/_src/kubernetes-ingress-controller/upgrade/kic.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ ingressController:
### Update Gateway API
#### Update Gateway API from v1.0 to v1.1
#### From v1.0 to v1.1
Starting from version 3.2, {{ site.kic_product_name }} supports Gateway API version 1.1.
The primary change in Gateway API v1.1 is the promotion of GRPCRoute from v1alpha2 to v1.
Expand Down Expand Up @@ -77,7 +77,7 @@ complete the following steps to upgrade to version v1.1 of the CRD:

{% if_version gte:3.4.x %}

#### Update Gateway API from v1.1 to v1.2
#### From v1.1 to v1.2

Starting from version 3.4, {{ site.kic_product_name }} supports Gateway API version 1.2.
There is a breaking change in gateway API 1.2 to remove the `v1alpha2` version of `GRPCRoute` and `ReferenceGrant`.
Expand All @@ -89,9 +89,10 @@ You can use the following script to ensure your `GRPCRoute` and `ReferenceGrant`
kubectl get grpcroutes -A -o jsonpath='{.items[*].apiVersion}' | tr ' ' '\n' | sort | uniq -c
kubectl get referencegrants -A -o jsonpath='{.items[*].apiVersion}' | tr ' ' '\n' | sort | uniq -c
```
If any of the output contains `v1alpha2`, it means that there are `GRPCRoute` or `ReferenceGrant` (or both) using `v1alpha2` storage version and you need to update the manifests before upgrading.

Otherwise, upgrade gateway API and {{ site.kic_product_name }} following these steps:
If the output contains `v1alpha2`, it means that there are `GRPCRoute`s or `ReferenceGrant`s (or both) using `v1alpha2` storage version and you need to update the manifests before upgrading.

Otherwise, upgrade Gateway API and {{ site.kic_product_name }} following these steps:

1. Ensure you are using Gateway API 1.1 (you can upgrade by following the steps in the section above).
2. Ensure your are using {{ site.kic_product_name }} version 3.2 (or above).
Expand Down

0 comments on commit 3e4f1ec

Please sign in to comment.