Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: SNIs entity page #202

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Feat: SNIs entity page #202

merged 7 commits into from
Jan 10, 2025

Conversation

lmilan
Copy link
Contributor

@lmilan lmilan commented Jan 8, 2025

Preview Links

Checklist

  • Every page is page one
  • Tested how-to docs. If not, note why here.
  • All pages contain metadata
  • Updated sources.yaml. For more info review track docs changes
  • Any new docs link to existing docs.

@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Deploy Preview for kongdeveloper ready!

Name Link
🔨 Latest commit 2ced23a
🔍 Latest deploy log https://app.netlify.com/sites/kongdeveloper/deploys/678191c6708bbb000819c667
😎 Deploy Preview https://deploy-preview-202--kongdeveloper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lmilan lmilan marked this pull request as ready for review January 9, 2025 10:14
@lmilan lmilan requested a review from a team as a code owner January 9, 2025 10:14
cloudjumpercat
cloudjumpercat reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left an example diagram because I thought a diagram like that could help users understand the entity relationships better.

app/_gateway_entities/sni.md Show resolved Hide resolved
@Guaris Guaris self-requested a review January 10, 2025 21:33
@Guaris Guaris merged commit c9ef612 into main Jan 10, 2025
10 checks passed
@Guaris Guaris deleted the snis-entity branch January 10, 2025 21:36
@lena-larionova lena-larionova modified the milestones: Gateway core entities, Gateway entities Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudjumpercat cloudjumpercat cloudjumpercat left review comments

@Guaris Guaris Guaris approved these changes

Assignees

@Guaris Guaris

@cloudjumpercat cloudjumpercat

Labels
None yet
Projects
None yet
Milestone
Gateway entities
Development

Successfully merging this pull request may close these issues.
4 participants
@lmilan @Guaris @cloudjumpercat @lena-larionova