Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Workspaces #198

Merged
merged 12 commits into from
Jan 10, 2025
Merged

Feat: Workspaces #198

merged 12 commits into from
Jan 10, 2025

Conversation

Guaris
Copy link
Contributor

@Guaris Guaris commented Jan 7, 2025 •
edited
Loading

Preview Links

Todo in a separate PR:

Todo in this PR:
Create a mermaid diagram for the algorithm?

Checklist

  • Every page is page one
  • Tested how-to docs. If not, note why here.
  • All pages contain metadata
  • Updated sources.yaml. For more info review track docs changes
  • Any new docs link to existing docs.

@Guaris Guaris requested a review from a team as a code owner January 7, 2025 20:23
@netlify Netlify
Copy link

netlify bot commented Jan 7, 2025 •
edited
Loading

✅ Deploy Preview for kongdeveloper ready!

Name Link
🔨 Latest commit 427a757
🔍 Latest deploy log https://app.netlify.com/sites/kongdeveloper/deploys/6781810c78b1a70008f42013
😎 Deploy Preview https://deploy-preview-198--kongdeveloper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudjumpercat cloudjumpercat self-assigned this Jan 8, 2025
cloudjumpercat
cloudjumpercat requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions, let me know if you have questions! Happy to review this again; it's hard to visualize all the changes when moving content via GitHub suggestions.

app/_gateway_entities/workspace.md Outdated Show resolved Hide resolved
app/_gateway_entities/workspace.md Show resolved Hide resolved
app/_gateway_entities/workspace.md Outdated Show resolved Hide resolved
app/_gateway_entities/workspace.md Outdated Show resolved Hide resolved
app/_gateway_entities/workspace.md Outdated Show resolved Hide resolved
app/_gateway_entities/workspace.md Show resolved Hide resolved
app/_gateway_entities/workspace.md Outdated Show resolved Hide resolved
app/_gateway_entities/workspace.md Outdated Show resolved Hide resolved
app/_gateway_entities/workspace.md Outdated Show resolved Hide resolved
app/_landing_pages/gateway/multi-tenancy.yaml Show resolved Hide resolved
Guaris
Guaris commented Jan 9, 2025
View reviewed changes
app/_gateway_entities/workspace.md Outdated Show resolved Hide resolved
app/_gateway_entities/workspace.md Outdated Show resolved Hide resolved
This was referenced Jan 9, 2025
Closed
Closed
@lena-larionova lena-larionova linked an issue Jan 9, 2025 that may be closed by this pull request
Workspaces entity docs #206
Closed
@Guaris Guaris requested a review from cloudjumpercat January 9, 2025 21:04
cloudjumpercat
cloudjumpercat approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Applied a few small fixes, sorry. Only saw after that you were listed on Slack to apply any changes.

@Guaris Guaris merged commit 0ab1c07 into main Jan 10, 2025
10 checks passed
@Guaris Guaris deleted the workspace branch January 10, 2025 20:34
@lena-larionova lena-larionova added this to the Gateway core entities milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianrbz fabianrbz fabianrbz left review comments

@cloudjumpercat cloudjumpercat cloudjumpercat approved these changes

Assignees

@cloudjumpercat cloudjumpercat

Labels
None yet
Projects
None yet
Milestone
Gateway core entities
Development

Successfully merging this pull request may close these issues.

Workspaces entity docs
4 participants
@Guaris @fabianrbz @cloudjumpercat @lena-larionova