-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): create 'gateway' subcommand for network commands #962
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
==========================================
- Coverage 33.18% 32.75% -0.43%
==========================================
Files 102 103 +1
Lines 12582 12747 +165
==========================================
Hits 4175 4175
- Misses 8000 8165 +165
Partials 407 407 ☔ View full report in Codecov by Sentry. |
c4acd9a
to
ec9f9b7
Compare
@Tieske @GGabriele This should not be merged. We are not adding the |
339140e
to
4c87068
Compare
we cannot move the top-level flags now, since that would break the existing commands. That can only be done after we finally remove the compatibility-commands we keep at the top-level. |
4e37600
to
a4deec5
Compare
0a153b3
to
3db5260
Compare
f4479ba
to
525f850
Compare
525f850
to
55a779b
Compare
477aa82
to
f6edfa1
Compare
f6edfa1
to
693c99e
Compare
d59992d
to
5dcc32a
Compare
19ef437
to
d8de662
Compare
We should fix the tests as part of the d8de662 commit, but other than that LGTM! |
aa19342
to
33abcc8
Compare
for now we are more interested in reliability of the old-style (to not break anything). In a later stage we can revert this commit to switch the tests to the new cli again.
33abcc8
to
40f69eb
Compare
2 Cobra commands were generated; deprecated, and current. Both would point to the same golbal variable. The bug is that Cobra sets the defaults when CREATING the command not when parsing. This means that the last command created would set the global defaults, and hence overwrite the ones from the other command. Introduced in #962 Jira: DECK-156
2 Cobra commands were generated; deprecated, and current. Both would point to the same golbal variable. The bug is that Cobra sets the defaults when CREATING the command not when parsing. This means that the last command created would set the global defaults, and hence overwrite the ones from the other command. Introduced in #962 Jira: DECK-156
2 Cobra commands were generated; deprecated, and current. Both would point to the same golbal variable. The bug is that Cobra sets the defaults when CREATING the command not when parsing. This means that the last command created would set the global defaults, and hence overwrite the ones from the other command. Introduced in #962 Jira: DECK-156
2 Cobra commands were generated; deprecated, and current. Both would point to the same golbal variable. The bug is that Cobra sets the defaults when CREATING the command not when parsing. This means that the last command created would set the global defaults, and hence overwrite the ones from the other command. Introduced in #962 Jira: DECK-156
2 Cobra commands were generated; deprecated, and current. Both would point to the same golbal variable. The bug is that Cobra sets the defaults when CREATING the command not when parsing. This means that the last command created would set the global defaults, and hence overwrite the ones from the other command. Introduced in #962 Jira: DECK-156
This introduces the
gateway
sub-command, and moves the existing commands under the new sub-command. Since aliases are in place this is non-breaking.The old commands will now display a deprecation warning.
New structure:
Todo:
file validate
which was removed by chore(validate): remove validate again from file subcommand #971Jira: APIOPS-98