Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add GOTESTFLAGS to test-integration Makefile target #1462

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Dec 4, 2024

Fixes #1461

@pmalek pmalek self-assigned this Dec 4, 2024
@pmalek pmalek added the testing label Dec 4, 2024
@pmalek pmalek marked this pull request as ready for review December 4, 2024 21:14
@pmalek pmalek requested a review from GGabriele December 4, 2024 21:14
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.58%. Comparing base (9c2f736) to head (0f08a01).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1462   +/-   ##
=======================================
  Coverage   27.58%   27.58%           
=======================================
  Files          61       61           
  Lines        6285     6285           
=======================================
  Hits         1734     1734           
  Misses       4423     4423           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek changed the title tests: fix Konnect integration tests tests: add GOTESTFLAGS to test-integration Makefile target Dec 12, 2024
@pmalek
Copy link
Member Author

pmalek commented Dec 12, 2024

It looks like the Konnect integration issue has been solved in #1470. 👍

Merging this to add the GOTESTFLAGS param to Makefile

@pmalek pmalek merged commit 9c52126 into main Dec 12, 2024
19 checks passed
@pmalek pmalek deleted the fix-konnect-integration-tests branch December 12, 2024 13:07
battlebyte pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Konnect integration test Test_Dump_SkipConsumers_Konnect failing
3 participants