-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feature online plugins filter flag #1458
Conversation
Deck is adding lots of these "only X" or "skip Y" flags. Can we make this more generic, so that they can pass something like:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1458 +/- ##
==========================================
+ Coverage 27.55% 27.59% +0.04%
==========================================
Files 61 61
Lines 6294 6283 -11
==========================================
Hits 1734 1734
+ Misses 4432 4421 -11
Partials 128 128 ☔ View full report in Codecov by Sentry. |
@mheap sure I was actually thinking about something similar first. Let me refactor this PR For info it really does have a nice impact on performance, here a test with a small file: Performance are almost 40% to 50% better |
@mheap can you confirm it looks ok or do you want me to edit the flag name? I will then ask for review for this PR. Thanks FlagName: Entities should be part of the EntitiesMap: RBACEndpointPermissions, RBACRoles, Plugins, Services, ACLGroups, BasicAuths, CACertificates, Certificates, Consumers, Documents, HMACAuths, JWTAuths, KeyAuths, Oauth2Creds, Routes, SNIs, Targets, Upstreams, FilterChains, Vaults. |
fix reflection add test fix lint fix lint add valid entities fux lint Updated go-apiops (#1452) * chore: updated go-apiops to v0.1.40 * chore: release prep for v1.41.4 fux lint fix lint fix lint
beb2319
to
6fe17ee
Compare
Any update on this? Thanks |
@Prashansa-K Please review |
c74b7cf
to
1358190
Compare
189e17d
to
3669938
Compare
e3d0680
to
2273715
Compare
589b1cf
to
4862fa7
Compare
Add a new flag to only validate plugins online