Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): import kubernetes-configuration instead of KIC #1450

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Nov 22, 2024

There is new source of truth - kubernetes-configuration for all CRDs maintained by team-k8s (KIC and KGO related), so it should be imported and used instead of KIC.

Closes Kong/kubernetes-ingress-controller#6641

@programmer04 programmer04 added the dependencies Pull requests that update a dependency file label Nov 22, 2024
@programmer04 programmer04 self-assigned this Nov 22, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2024

CLA assistant check
All committers have signed the CLA.

@programmer04 programmer04 enabled auto-merge (squash) November 22, 2024 12:22
@programmer04 programmer04 requested review from a team and removed request for a team November 22, 2024 12:22
@programmer04 programmer04 added the go Pull requests that update Go code label Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 82.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 27.55%. Comparing base (63dc5b4) to head (96990b8).

Files with missing lines Patch % Lines
kong2kic/upstream.go 80.00% 4 Missing ⚠️
kong2kic/global_plugin.go 75.00% 1 Missing ⚠️
kong2kic/route.go 50.00% 1 Missing ⚠️
kong2kic/utils.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1450   +/-   ##
=======================================
  Coverage   27.55%   27.55%           
=======================================
  Files          61       61           
  Lines        6294     6294           
=======================================
  Hits         1734     1734           
  Misses       4432     4432           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 force-pushed the deps-rm-kic branch 2 times, most recently from 2bc79b6 to 112db2d Compare November 25, 2024 09:04
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding a golangcilint rule that will prevent using KIC types.

.golangci.yml Outdated Show resolved Hide resolved
@programmer04 programmer04 merged commit 43eef06 into main Nov 26, 2024
19 checks passed
@programmer04 programmer04 deleted the deps-rm-kic branch November 26, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate deck from to kubernetes-configuration
4 participants