-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): import kubernetes-configuration instead of KIC #1450
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1450 +/- ##
=======================================
Coverage 27.55% 27.55%
=======================================
Files 61 61
Lines 6294 6294
=======================================
Hits 1734 1734
Misses 4432 4432
Partials 128 128 ☔ View full report in Codecov by Sentry. |
2bc79b6
to
112db2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider adding a golangcilint rule that will prevent using KIC types.
112db2d
to
0b59a83
Compare
0b59a83
to
74fdcd4
Compare
74fdcd4
to
2b95712
Compare
4278e32
to
96990b8
Compare
There is new source of truth - kubernetes-configuration for all CRDs maintained by team-k8s (KIC and KGO related), so it should be imported and used instead of KIC.
Closes Kong/kubernetes-ingress-controller#6641