Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing integration test failures for 3.8.1 release #1428

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

Prashansa-K
Copy link
Contributor

@Prashansa-K Prashansa-K commented Oct 28, 2024

@Prashansa-K Prashansa-K requested a review from GGabriele October 28, 2024 10:21
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.51%. Comparing base (8e377a0) to head (de79714).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1428   +/-   ##
=======================================
  Coverage   27.51%   27.51%           
=======================================
  Files          61       61           
  Lines        6272     6272           
=======================================
  Hits         1726     1726           
  Misses       4423     4423           
  Partials      123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Prashansa-K Prashansa-K self-assigned this Oct 29, 2024
@Prashansa-K
Copy link
Contributor Author

@GGabriele Reminding for review on this.

@Prashansa-K Prashansa-K requested a review from pmalek November 6, 2024 07:44
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice to include a short description and ideally a link to failing CI to show what we're actually trying to fix.

👍

@Prashansa-K Prashansa-K merged commit c88f497 into main Nov 6, 2024
19 checks passed
@Prashansa-K Prashansa-K deleted the fix/integration-test-failures-3.8 branch November 6, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants