ci: use license action #1103
Merged
ci: use license action #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
use-license-action
branch
from
ba701d5 to
1e7e4b0
Compare
Tieske
reviewed
Nov 10, 2023
Comment on lines
+50
to
+51
| env: | ||
| KONG_LICENSE_DATA: ${{ steps.license.outputs.license }} |
There was a problem hiding this comment.
see https://github.com/Kong/kong-license#github-action
This shouldn't be necessary to set the ENV explicitly, the action will already have it set (exported). There are multiple occurrences of this.
Unless the explicitness of the current approach is preferred, then this is fine.
There was a problem hiding this comment.
I forgot about this feature of license action but yes:
Unless the explicitness of the current approach is preferred, then this is fine.
IMHO this might make it easier for the readers that do not know this hidden (albeit documented!) behavior of this action.
AntoineJac
pushed a commit
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use https://github.com/Kong/kong-license/ instead of manually updated secret. 🤖
Also while at it, change the order of steps in tests to utilize Go cache. Without this change repo is not checked out when go is being set up: