fix: handle tags for old consumer-groups implementation #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tags support for Consumer Groups was introduced in 3.2.
Before that, making a request with a tag would have no
effect in the Gateway:
```
$ http :8001/plugins\?tags=foo
HTTP/1.1 200 OK
{
"data": [],
"next": null
}
$ http :8001/consumer_groups\?tags=foo
HTTP/1.1 200 OK
{
"data": [
{
"created_at": 1699337744,
"id": "d241ee7f-875a-41f1-84fb-c509df9e716e",
"name": "my-cg"
}
],
"next": null
}
```
For this reason, when a Consumer Group is present and a `sync` with
`select_tags` is ran, the existing Consumer Group is wiped out.
This commit introduces a custom way to handle tags for Consumer Groups
when the `select_tags` is present in the input. This doesn't mean
we are implementing tags support for older versions of the Gateway,
but it means that if a Consumer Group (without a tag) exists, it won't
be wiped out when a `sync` with `select_tags` is ran.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
==========================================
- Coverage 32.87% 32.78% -0.09%
==========================================
Files 103 103
Lines 12850 12885 +35
==========================================
Hits 4224 4224
- Misses 8217 8252 +35
Partials 409 409
☔ View full report in Codecov by Sentry. |
aboudreault
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags support for Consumer Groups was introduced in 3.2. Before that, making a request with a tag would have no effect in the Gateway:
For this reason, when a Consumer Group is present and a
syncwithselect_tagsis ran, the existing Consumer Group is wiped out.This commit introduces a custom way to handle tags for Consumer Groups when the
select_tagsis present in the input. This doesn't mean we are implementing tags support for older versions of the Gateway, but it means that if a Consumer Group (without a tag) exists, it won't be wiped out when asyncwithselect_tagsis ran.