Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add nolint directive to make golangci-lint happy #1069

Closed
wants to merge 1 commit into from
Closed

chore: add nolint directive to make golangci-lint happy #1069

wants to merge 1 commit into from

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 31, 2023

This PR prevents:

make lint
golangci-lint run ./...
types/core.go:111:2: G101: Potential hardcoded credentials (gosec)
        RBACEndpointPermission EntityType = "rbac-endpoint-permission"
        ^

@pmalek pmalek self-assigned this Oct 31, 2023
@pmalek pmalek requested a review from a team October 31, 2023 14:43
@pmalek pmalek enabled auto-merge (squash) October 31, 2023 14:43
@pmalek
Copy link
Member Author

pmalek commented Oct 31, 2023

Not an issue when using an updated:

$ golangci-lint version
golangci-lint has version v1.55.1 built with go1.21.3 from (unknown, mod sum: "h1:DL2j9Eeapg1N3WEkKnQFX5L40SYtjZZJjGVdyEgNrDc=") on (unknown)

@pmalek pmalek closed this Oct 31, 2023
auto-merge was automatically disabled October 31, 2023 14:49

Pull request was closed

@pmalek pmalek deleted the fix-linter branch October 31, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pmalek pmalek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pmalek