Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(apiops): bump apiops to v0.1.23 #1064

Merged
merged 3 commits into from
Oct 31, 2023
Merged

deps(apiops): bump apiops to v0.1.23 #1064

merged 3 commits into from
Oct 31, 2023

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Oct 27, 2023

Bump go-apiops;

  • patch: allow patch command to operate on arrays
  • o2k: flag to generate inso compatible names, and skip IDs

Jira: APIOPS-88, APIOPS-96

@Tieske Tieske marked this pull request as ready for review October 27, 2023 21:19
@Tieske Tieske requested a review from a team October 27, 2023 21:19
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (d90f7e3) 33.18% compared to head (0e06cbe) 33.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
- Coverage   33.18%   33.13%   -0.05%     
==========================================
  Files         102      102              
  Lines       12582    12600      +18     
==========================================
  Hits         4175     4175              
- Misses       8000     8018      +18     
  Partials      407      407              
Files Coverage Δ
cmd/file_openapi2kong.go 0.00% <0.00%> (ø)
cmd/file_patch.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GGabriele
Copy link
Collaborator

Merging #1065 and rebasing this PR will correct the failures.

This will generate a deck config without ids, and the generated
names will be the same as Inso.
@Tieske Tieske merged commit 1982995 into main Oct 31, 2023
33 of 34 checks passed
@Tieske Tieske deleted the bump/apiops branch October 31, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants