feat: make expressions router default #939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
czeslavo
force-pushed
the
ingress-router-flavor-expressions
branch
from
488dfd3 to
1f0dc28
Compare
czeslavo
force-pushed
the
ingress-router-flavor-expressions
branch
4 times, most recently
from
5f529f9 to
4b2e7f2
Compare
czeslavo
force-pushed
the
ingress-router-flavor-expressions
branch
from
4b2e7f2 to
830bccb
Compare
randmonkey
reviewed
Nov 10, 2023
charts/ingress/values.yaml
Outdated
| @@ -44,3 +44,4 @@ gateway: | |||
| env: | |||
| role: traditional | |||
| database: "off" | |||
| router_flavor: "expressions" | |||
There was a problem hiding this comment.
Could we add a template to check image of KIC?
There was a problem hiding this comment.
Can you please elaborate on what you mean by this? There are two validation rules added in validations.tpl file: one for KIC < 2.10 and one for KIC < 3.0.
czeslavo
changed the title
czeslavo
force-pushed
the
ingress-router-flavor-expressions
branch
from
1becd23 to
d61f920
Compare
czeslavo
force-pushed
the
ingress-router-flavor-expressions
branch
from
d61f920 to
d777988
Compare
|
Per @mheap, I'm labeling this with |
|
Could potentially be put in |
auto-merge was automatically disabled
March 27, 2024 10:10
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sets the expression router as default in
kong/kong. Adds validations that ensure that:expressionsrouter flavor is not used with KIC < 2.10 as it's not supportedexpressionsrouter flavor is used with KIC < 3.0, the feature gate must be set.to both
kong/kongandkong/ingresscharts.Validations will output instructions on how to fix the issue if it is encountered.
It also changes the way we refer to
kong/konginkong/ingress'sChart.yaml: instead of using the repository URL that forces us to bump charts in two steps, usefile://to make it possible in one step.Which issue this PR fixes
Should solve #1188.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.