Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conf): Add support for excludeMigrationPod to userDefinedVolumes and userDefinedVolumeMounts #1176

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ashman1984
Copy link
Contributor

What this PR does / why we need it:

At the moment Kong threats migrations PODs the same way as proxy PODs, and mounts all user defined PVs to both proxy and migration PODs.

While this might be useful in some situations, in most cases it is unnecessary to have user defined volumes mounted to migration PODs, and in some cases even not desired by the user.

This PR allows users to exclude user defined PODs from being mounted for migration.

This could be possible in the following ways:

  1. Introduce additional property to _ userDefinedVolumeMounts_ and _ userDefinedVolumes_ to allows exclusion of user defined PODs from being mounted to migration jobs.

  2. Obsolete current userDefinedVolumeMounts and _ userDefinedVolumes_ properties (located under root element "deployment") in favour of dedicated mounts for proxy and migration in a similar fashion as it is done for the ingress controller, where userDefinedVolumeMounts and _ userDefinedVolumes_ are defined under "ingressController" root property.

This might be done by adding userDefinedVolumeMounts and _ userDefinedVolumes_ under root section called "migrations" for migrations PODs, and for proxy under root section "proxy".

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@ashman1984 ashman1984 requested a review from a team as a code owner November 29, 2024 04:01
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the change. Can you please rebase on latest tip of main and add a ci values file so that we can test it in CI?

This will require running make test.golden.update to update the golden files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants