feat(conf): Add support for excludeMigrationPod
to userDefinedVolumes and userDefinedVolumeMounts
#1176
+61
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
At the moment Kong threats migrations PODs the same way as proxy PODs, and mounts all user defined PVs to both proxy and migration PODs.
While this might be useful in some situations, in most cases it is unnecessary to have user defined volumes mounted to migration PODs, and in some cases even not desired by the user.
This PR allows users to exclude user defined PODs from being mounted for migration.
This could be possible in the following ways:
Introduce additional property to _ userDefinedVolumeMounts_ and _ userDefinedVolumes_ to allows exclusion of user defined PODs from being mounted to migration jobs.
Obsolete current userDefinedVolumeMounts and _ userDefinedVolumes_ properties (located under root element "deployment") in favour of dedicated mounts for proxy and migration in a similar fashion as it is done for the ingress controller, where userDefinedVolumeMounts and _ userDefinedVolumes_ are defined under "ingressController" root property.
This might be done by adding userDefinedVolumeMounts and _ userDefinedVolumes_ under root section called "migrations" for migrations PODs, and for proxy under root section "proxy".
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
main
branch.