Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart uses the expression router by default #1188

Open
1 of 2 tasks
mflendrich opened this issue Nov 8, 2023 · 2 comments · May be fixed by #935
Open
1 of 2 tasks

Chart uses the expression router by default #1188

mflendrich opened this issue Nov 8, 2023 · 2 comments · May be fixed by #935
Assignees
@randmonkey
Labels
breaking-change
Milestone
Kong v3

Comments

@mflendrich
Copy link
Contributor

mflendrich commented Nov 8, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

The Helm chart installs KIC+Kong with the expression router enabled by default IF KIC is >= 3.0.

Proposed Solution

ditto

Additional information

No response

Acceptance Criteria

  • If helm installing with KIC 3.0 using the official instructions in the docs, the helm chart sets the router flavor to expression unless overridden
@randmonkey randmonkey self-assigned this Nov 9, 2023
@randmonkey randmonkey linked a pull request Nov 9, 2023 that will close this issue
Open
4 tasks
@czeslavo czeslavo mentioned this issue Nov 9, 2023
Closed
4 tasks
@lahabana lahabana transferred this issue from Kong/kubernetes-ingress-controller Dec 4, 2024
@lahabana
Copy link
Collaborator

lahabana commented Dec 4, 2024

There used to be a reason why we couldn't do this just yet (maybe Konnect not supporting expression router at the time).
Whoever takes this issue should probably do some investigation on this

@pmalek pmalek added this to the Kong v3 milestone Dec 4, 2024
@pmalek
Copy link
Member

pmalek commented Dec 4, 2024

Adding the breaking-change label and putting into v3 as that would be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@randmonkey randmonkey

Labels
breaking-change
Projects
None yet
Milestone
Kong v3
4 participants
@lahabana @pmalek @mflendrich @randmonkey